Sink should create dir, update docs for output flag of eval, render (#2215)

* Sink should create dir, update docs for output flag of eval, render

* Reconcile e2e tests

* Fix oop tests

* fix test

* Error if directory already exists

* Fix e2e tests

* Add more e2e tests

* Update book

* Make directory check preRun

* Update generated docs

* Update r.dest

* Update hydrated name

* Separate sink tests

Author: phanimarupaka

e2e/fn_test.go

@@ -31,6 +31,10 @@ func TestFnEval(t *testing.T) {
 	runAllTests(t, filepath.Join(".", "testdata", "fn-eval"))
 }
 
+func TestFnSink(t *testing.T) {
+	runAllTests(t, filepath.Join(".", "testdata", "fn-sink"))
+}
+
 // runTests will scan test cases in 'path', run the command
 // on all of the packages in path, and test that
 // the diff between the results and the original package is as

e2e/testdata/fn-eval/fn-source/exclude-meta-resources-by-default-out-of-place/.expected/diff.patch

@@ -1,58 +1,34 @@
-diff --git a/Kptfile b/Kptfile
-deleted file mode 100644
-index 39dec05..0000000
---- a/Kptfile
-+++ /dev/null
-@@ -1,8 +0,0 @@
--apiVersion: kpt.dev/v1alpha2
--kind: Kptfile
--metadata:
--  name: app
--pipeline:
--  mutators:
--    - image: gcr.io/kpt-fn/set-labels:v0.1.4
--      configPath: labelconfig.yaml
-diff --git a/labelconfig.yaml b/labelconfig.yaml
-deleted file mode 100644
-index 7ef9890..0000000
---- a/labelconfig.yaml
-+++ /dev/null
-@@ -1,19 +0,0 @@
--# Copyright 2021 Google LLC
--#
--# Licensed under the Apache License, Version 2.0 (the "License");
--# you may not use this file except in compliance with the License.
--# You may obtain a copy of the License at
--#
--#      http://www.apache.org/licenses/LICENSE-2.0
--#
--# Unless required by applicable law or agreed to in writing, software
--# distributed under the License is distributed on an "AS IS" BASIS,
--# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
--# See the License for the specific language governing permissions and
--# limitations under the License.
--apiVersion: v1
--kind: ConfigMap
--metadata:
--  name: label-config
--data:
--  tier: app
-diff --git a/resources.yaml b/resources.yaml
-index 7a494c9..254b9cd 100644
---- a/resources.yaml
-+++ b/resources.yaml
-@@ -15,6 +15,7 @@ apiVersion: apps/v1
- kind: Deployment
- metadata:
-   name: nginx-deployment
+diff --git a/out/resources.yaml b/out/resources.yaml
+new file mode 100644
+index 0000000..254b9cd
+--- /dev/null
++++ b/out/resources.yaml
+@@ -0,0 +1,28 @@
++# Copyright 2021 Google LLC
++#
++# Licensed under the Apache License, Version 2.0 (the "License");
++# you may not use this file except in compliance with the License.
++# You may obtain a copy of the License at
++#
++#      http://www.apache.org/licenses/LICENSE-2.0
++#
++# Unless required by applicable law or agreed to in writing, software
++# distributed under the License is distributed on an "AS IS" BASIS,
++# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++# See the License for the specific language governing permissions and
++# limitations under the License.
++apiVersion: apps/v1
++kind: Deployment
++metadata:
++  name: nginx-deployment
 +  namespace: staging
- spec:
-   replicas: 3
- ---
-@@ -22,5 +23,6 @@ apiVersion: custom.io/v1
- kind: Custom
- metadata:
-   name: custom
++spec:
++  replicas: 3
++---
++apiVersion: custom.io/v1
++kind: Custom
++metadata:
++  name: custom
 +  namespace: staging
- spec:
-   image: nginx:1.2.3
++spec:
++  image: nginx:1.2.3

e2e/testdata/fn-eval/fn-source/exclude-meta-resources-by-default-out-of-place/.expected/exec.sh

@@ -15,16 +15,8 @@
 
 set -eo pipefail
 
-# create a temporary directory
-TEMP_DIR=$(mktemp -d)
+rm -rf out
 
 kpt fn source\
 | kpt fn eval - --image gcr.io/kpt-fn/set-namespace:v0.1.3 -- namespace=staging \
-| kpt fn sink $TEMP_DIR
-
-# copy back the resources
-rm -r ./*
-cp $TEMP_DIR/* .
-
-# remove temporary directory
-rm -r $TEMP_DIR
+| kpt fn sink out

e2e/testdata/fn-eval/fn-source/exclude-meta-resources-by-default-out-of-place/.krmignore

@@ -1 +1,2 @@
 .expected
+out

e2e/testdata/fn-eval/fn-source/exclude-meta-resources-by-default/.expected/diff.patch

@@ -1,19 +1,34 @@
-diff --git a/resources.yaml b/resources.yaml
-index 7a494c9..254b9cd 100644
---- a/resources.yaml
-+++ b/resources.yaml
-@@ -15,6 +15,7 @@ apiVersion: apps/v1
- kind: Deployment
- metadata:
-   name: nginx-deployment
+diff --git a/out/resources.yaml b/out/resources.yaml
+new file mode 100644
+index 0000000..254b9cd
+--- /dev/null
++++ b/out/resources.yaml
+@@ -0,0 +1,28 @@
++# Copyright 2021 Google LLC
++#
++# Licensed under the Apache License, Version 2.0 (the "License");
++# you may not use this file except in compliance with the License.
++# You may obtain a copy of the License at
++#
++#      http://www.apache.org/licenses/LICENSE-2.0
++#
++# Unless required by applicable law or agreed to in writing, software
++# distributed under the License is distributed on an "AS IS" BASIS,
++# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++# See the License for the specific language governing permissions and
++# limitations under the License.
++apiVersion: apps/v1
++kind: Deployment
++metadata:
++  name: nginx-deployment
 +  namespace: staging
- spec:
-   replicas: 3
- ---
-@@ -22,5 +23,6 @@ apiVersion: custom.io/v1
- kind: Custom
- metadata:
-   name: custom
++spec:
++  replicas: 3
++---
++apiVersion: custom.io/v1
++kind: Custom
++metadata:
++  name: custom
 +  namespace: staging
- spec:
-   image: nginx:1.2.3
++spec:
++  image: nginx:1.2.3

e2e/testdata/fn-eval/fn-source/exclude-meta-resources-by-default/.expected/exec.sh

@@ -15,6 +15,8 @@
 
 set -eo pipefail
 
+rm -rf out
+
 kpt fn source \
 | kpt fn eval - --image gcr.io/kpt-fn/set-namespace:v0.1.3 -- namespace=staging \
-| kpt fn sink
+| kpt fn sink out

e2e/testdata/fn-eval/fn-source/include-meta-resource-out-of-place/.expected/diff.patch

@@ -1,42 +1,75 @@
-diff --git a/Kptfile b/Kptfile
-index 39dec05..47f7bf4 100644
---- a/Kptfile
-+++ b/Kptfile
-@@ -2,6 +2,7 @@ apiVersion: kpt.dev/v1alpha2
- kind: Kptfile
- metadata:
-   name: app
+diff --git a/out/Kptfile b/out/Kptfile
+new file mode 100644
+index 0000000..47f7bf4
+--- /dev/null
++++ b/out/Kptfile
+@@ -0,0 +1,9 @@
++apiVersion: kpt.dev/v1alpha2
++kind: Kptfile
++metadata:
++  name: app
 +  namespace: staging
- pipeline:
-   mutators:
-     - image: gcr.io/kpt-fn/set-labels:v0.1.4
-diff --git a/labelconfig.yaml b/labelconfig.yaml
-index 7ef9890..f3a8b49 100644
---- a/labelconfig.yaml
-+++ b/labelconfig.yaml
-@@ -15,5 +15,6 @@ apiVersion: v1
- kind: ConfigMap
- metadata:
-   name: label-config
++pipeline:
++  mutators:
++    - image: gcr.io/kpt-fn/set-labels:v0.1.4
++      configPath: labelconfig.yaml
+diff --git a/out/labelconfig.yaml b/out/labelconfig.yaml
+new file mode 100644
+index 0000000..f3a8b49
+--- /dev/null
++++ b/out/labelconfig.yaml
+@@ -0,0 +1,20 @@
++# Copyright 2021 Google LLC
++#
++# Licensed under the Apache License, Version 2.0 (the "License");
++# you may not use this file except in compliance with the License.
++# You may obtain a copy of the License at
++#
++#      http://www.apache.org/licenses/LICENSE-2.0
++#
++# Unless required by applicable law or agreed to in writing, software
++# distributed under the License is distributed on an "AS IS" BASIS,
++# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++# See the License for the specific language governing permissions and
++# limitations under the License.
++apiVersion: v1
++kind: ConfigMap
++metadata:
++  name: label-config
 +  namespace: staging
- data:
-   tier: app
-diff --git a/resources.yaml b/resources.yaml
-index 7a494c9..254b9cd 100644
---- a/resources.yaml
-+++ b/resources.yaml
-@@ -15,6 +15,7 @@ apiVersion: apps/v1
- kind: Deployment
- metadata:
-   name: nginx-deployment
++data:
++  tier: app
+diff --git a/out/resources.yaml b/out/resources.yaml
+new file mode 100644
+index 0000000..254b9cd
+--- /dev/null
++++ b/out/resources.yaml
+@@ -0,0 +1,28 @@
++# Copyright 2021 Google LLC
++#
++# Licensed under the Apache License, Version 2.0 (the "License");
++# you may not use this file except in compliance with the License.
++# You may obtain a copy of the License at
++#
++#      http://www.apache.org/licenses/LICENSE-2.0
++#
++# Unless required by applicable law or agreed to in writing, software
++# distributed under the License is distributed on an "AS IS" BASIS,
++# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++# See the License for the specific language governing permissions and
++# limitations under the License.
++apiVersion: apps/v1
++kind: Deployment
++metadata:
++  name: nginx-deployment
 +  namespace: staging
- spec:
-   replicas: 3
- ---
-@@ -22,5 +23,6 @@ apiVersion: custom.io/v1
- kind: Custom
- metadata:
-   name: custom
++spec:
++  replicas: 3
++---
++apiVersion: custom.io/v1
++kind: Custom
++metadata:
++  name: custom
 +  namespace: staging
- spec:
-   image: nginx:1.2.3
++spec:
++  image: nginx:1.2.3

e2e/testdata/fn-eval/fn-source/include-meta-resource-out-of-place/.expected/exec.sh

@@ -15,16 +15,8 @@
 
 set -eo pipefail
 
-# create a temporary directory
-TEMP_DIR=$(mktemp -d)
+rm -rf out
 
 kpt fn source --include-meta-resources\
 | kpt fn eval - --image gcr.io/kpt-fn/set-namespace:v0.1.3 -- namespace=staging \
-| kpt fn sink $TEMP_DIR
-
-# copy back the resources
-rm -r ./*
-cp $TEMP_DIR/* .
-
-# remove temporary directory
-rm -r $TEMP_DIR
+| kpt fn sink out

e2e/testdata/fn-eval/fn-source/include-meta-resource-out-of-place/.krmignore

@@ -1 +1,2 @@
 .expected
+out