Remove Temporary Upgrade Code (#3055)

Author: martinmaly

porch/apiserver/pkg/registry/porch/background.go

@@ -153,14 +153,6 @@ func (b *background) runOnce(ctx context.Context) error {
 	for i := range repositories.Items {
 		repo := &repositories.Items[i]
 
-		if repo.Spec.Content == "PackageRevision" {
-			// Upgrade to "Package"
-			repo.Spec.Content = configapi.RepositoryContentPackage
-			if err := b.coreClient.Update(ctx, repo); err != nil {
-				klog.Errorf("Failed to upgrade Repo content PackageRevision --> Package: %v", err)
-			}
-		}
-
 		if err := b.cacheRepository(ctx, repo); err != nil {
 			klog.Errorf("Failed to cache repository: %v", err)
 		}

porch/repository/pkg/cache/cache.go

@@ -127,14 +127,7 @@ func (c *Cache) OpenRepository(ctx context.Context, repositorySpec *configapi.Re
 }
 
 func isPackageContent(content configapi.RepositoryContent) bool {
-	switch content {
-	case "PackageRevision":
-		return true // TODO: remove this once migration to "Package" is complete.
-	case configapi.RepositoryContentPackage:
-		return true
-	default:
-		return false
-	}
+	return content == configapi.RepositoryContentPackage
 }
 
 func (c *Cache) CloseRepository(repositorySpec *configapi.Repository) error {