Skip to content

Commit 81aa585

Browse files
Update design doc review process (#2594)
1 parent 1ebda55 commit 81aa585

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

docs/design-docs/00-template.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,17 @@ here as well as citing *why* you decided not to pursue those paths.
7070
### \<Approach\>
7171

7272
Links and description of the approach, the pros and cons identified during the
73-
design.
73+
design.
74+
75+
# Review Process
76+
77+
Design doc creators should raise the pull request similar to [this](https://github.com/GoogleContainerTools/kpt/pull/2576).
78+
Reviewers are auto-assigned to review the PR. Optionally, doc owner can mention any
79+
specific reviewers on the PR description. The turn around time for each review cycle
80+
on the PR from kpt maintainers is 1-2 days. After maintainers add comments to the PR,
81+
doc owner should respond to each of those comments and hit `Resolve conversation` button on the
82+
comment thread. Once all the comments are resolved, design doc creator should hit `Re-request review`
83+
icon next to each reviewers' avatar in reviewers section. Reviewers will then be notified and, they will go through the
84+
resolved comments and might reopen the comment threads, and the cycle continues.
85+
Once all the reviewers approve the PR, it will be merged by the maintainers.
86+
Any design doc PRs which are not attended by the doc creators for more than 2 weeks will be closed.

0 commit comments

Comments
 (0)