File tree Expand file tree Collapse file tree 1 file changed +14
-1
lines changed Expand file tree Collapse file tree 1 file changed +14
-1
lines changed Original file line number Diff line number Diff line change @@ -70,4 +70,17 @@ here as well as citing *why* you decided not to pursue those paths.
70
70
### \< Approach\>
71
71
72
72
Links and description of the approach, the pros and cons identified during the
73
- design.
73
+ design.
74
+
75
+ # Review Process
76
+
77
+ Design doc creators should raise the pull request similar to [ this] ( https://github.com/GoogleContainerTools/kpt/pull/2576 ) .
78
+ Reviewers are auto-assigned to review the PR. Optionally, doc owner can mention any
79
+ specific reviewers on the PR description. The turn around time for each review cycle
80
+ on the PR from kpt maintainers is 1-2 days. After maintainers add comments to the PR,
81
+ doc owner should respond to each of those comments and hit ` Resolve conversation ` button on the
82
+ comment thread. Once all the comments are resolved, design doc creator should hit ` Re-request review `
83
+ icon next to each reviewers' avatar in reviewers section. Reviewers will then be notified and, they will go through the
84
+ resolved comments and might reopen the comment threads, and the cycle continues.
85
+ Once all the reviewers approve the PR, it will be merged by the maintainers.
86
+ Any design doc PRs which are not attended by the doc creators for more than 2 weeks will be closed.
You can’t perform that action at this time.
0 commit comments