Fix issue with multiple RESTMappers for live (#2375)

* Fix issue with multiple RESTMappers for live

* Address comments

Author: mortent

commands/livecmd.go

@@ -34,6 +34,7 @@ import (
 	cluster "k8s.io/kubectl/pkg/cmd/util"
 	"sigs.k8s.io/cli-utils/pkg/manifestreader"
 	"sigs.k8s.io/cli-utils/pkg/provider"
+	"sigs.k8s.io/cli-utils/pkg/util/factory"
 )
 
 func GetLiveCommand(ctx context.Context, _, version string) *cobra.Command {
@@ -79,8 +80,14 @@ func newFactory(cmd *cobra.Command, version string) cluster.Factory {
 	flags := cmd.PersistentFlags()
 	kubeConfigFlags := genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag()
 	kubeConfigFlags.AddFlags(flags)
+	// Use the CachingRESTClientGetter to make sure the same RESTMapper is shared
+	// across all kpt live functionality. This is needed to properly invalidate the
+	// RESTMapper cache when CRDs have been installed in the cluster.
+	cachingConfigFlags := &factory.CachingRESTClientGetter{
+		Delegate: kubeConfigFlags,
+	}
 	userAgentKubeConfigFlags := &cfgflags.UserAgentKubeConfigFlags{
-		Delegate:  kubeConfigFlags,
+		Delegate:  cachingConfigFlags,
 		UserAgent: fmt.Sprintf("kpt/%s", version),
 	}
 	cmd.PersistentFlags().AddGoFlagSet(flag.CommandLine)

internal/cmdfndoc/cmdfndoc.go

@@ -23,8 +23,8 @@ import (
 	"os/exec"
 
 	"github.com/GoogleContainerTools/kpt/internal/docs/generated/fndocs"
-	"github.com/GoogleContainerTools/kpt/internal/printer"
 	"github.com/GoogleContainerTools/kpt/internal/fnruntime"
+	"github.com/GoogleContainerTools/kpt/internal/printer"
 	"github.com/GoogleContainerTools/kpt/internal/util/cmdutil"
 	"github.com/spf13/cobra"
 )