Fix typos and code style issues

Author: jnm

jsapp/js/components/permissions/userAssetPermsEditor.es6

@@ -191,7 +191,7 @@ class UserAssetPermsEditor extends React.Component {
       stateObj.submissionsViewPartialUsers = [];
     }
 
-    // `formManage` implies every other permission (except parial permissions)
+    // `formManage` implies every other permission (except partial permissions)
     if (stateObj.formManage) {
       stateObj.formView = true;
       stateObj.formEdit = true;

kpi/migrations/0028_assign_manage_asset_permissions.py

@@ -7,7 +7,7 @@
 
 def create_new_perms(apps):
     """
-    The new `delete_submissions` permission does not exist when running this
+    The new `manage_asset` permission does not exist when running this
     migration for the first time. Django runs migrations in a transaction and
     new permissions are not created until after the transaction is completed.
 

kpi/models/asset.py

@@ -607,7 +607,7 @@ class Meta:
             (
                 p
                 for p in ASSIGNABLE_PERMISSIONS
-                if p != PERM_MANAGE_ASSET and p != PERM_PARTIAL_SUBMISSIONS
+                if p not in (PERM_MANAGE_ASSET, PERM_PARTIAL_SUBMISSIONS)
             )
         ),
         PERM_ADD_SUBMISSIONS: (PERM_VIEW_ASSET,),

kpi/models/object_permission.py

@@ -441,16 +441,16 @@ def _get_effective_perms(
 
         # Add the calculated `delete_` permission for the owner
         content_type = ContentType.objects.get_for_model(self)
-        if self.owner is not None and (
-                user is None or user.pk == self.owner.pk) and (
-                codename is None or codename.startswith('delete_')
+        if (
+            self.owner is not None
+            and (user is None or user.pk == self.owner.pk)
+            and (codename is None or codename.startswith('delete_'))
         ):
             matching_permissions = self.__get_permissions_for_content_type(
-                content_type.pk, codename__startswith='delete_')
+                content_type.pk, codename__startswith='delete_'
+            )
             for perm_pk, perm_codename in matching_permissions:
-                if (codename is not None and
-                        perm_codename != codename
-                ):
+                if codename is not None and perm_codename != codename:
                     # If the caller specified `codename`, skip anything that
                     # doesn't match exactly. Necessary because `Asset` has
                     # `delete_submissions` in addition to `delete_asset`

kpi/views/v1/asset.py

@@ -165,19 +165,28 @@ def get_serializer_class(self):
     def get_serializer_context(self):
         return super(AssetViewSetV2, self).get_serializer_context()
 
-    @action(detail=True, methods=["PATCH"], renderer_classes=[renderers.JSONRenderer])
+    @action(
+        detail=True,
+        methods=["PATCH"],
+        renderer_classes=[renderers.JSONRenderer],
+    )
     def permissions(self, request, uid):
         target_asset = self.get_object()
-        source_asset = get_object_or_404(Asset, uid=request.data.get(CLONE_ARG_NAME))
+        source_asset = get_object_or_404(
+            Asset, uid=request.data.get(CLONE_ARG_NAME)
+        )
         user = request.user
         response = {}
         http_status = status.HTTP_204_NO_CONTENT
 
-        if user.has_perm(PERM_MANAGE_ASSET, target_asset) and \
-                user.has_perm(PERM_VIEW_ASSET, source_asset):
+        if user.has_perm(PERM_MANAGE_ASSET, target_asset) and user.has_perm(
+            PERM_VIEW_ASSET, source_asset
+        ):
             if not target_asset.copy_permissions_from(source_asset):
                 http_status = status.HTTP_400_BAD_REQUEST
-                response = {"detail": "Source and destination objects don't seem to have the same type"}
+                response = {
+                    "detail": "Source and destination objects don't seem to have the same type"
+                }
         else:
             raise exceptions.PermissionDenied()
 

kpi/views/v2/collection_permission_assignment.py

@@ -175,20 +175,30 @@ def bulk_assignments(self, request, *args, **kwargs):
             # see all permissions.
             return self.list(request, *args, **kwargs)
 
-    @action(detail=False, methods=['PATCH'],
-            renderer_classes=[renderers.JSONRenderer])
+    @action(
+        detail=False,
+        methods=['PATCH'],
+        renderer_classes=[renderers.JSONRenderer],
+    )
     def clone(self, request, *args, **kwargs):
 
         source_collection_uid = self.request.data[CLONE_ARG_NAME]
-        source_collection = get_object_or_404(Collection, uid=source_collection_uid)
+        source_collection = get_object_or_404(
+            Collection, uid=source_collection_uid
+        )
         user = request.user
 
-        if ObjectPermissionHelper.user_can_share(self.collection, user) and \
-                user.has_perm(PERM_VIEW_COLLECTION, source_collection):
+        if ObjectPermissionHelper.user_can_share(
+            self.collection, user
+        ) and user.has_perm(PERM_VIEW_COLLECTION, source_collection):
             if not self.collection.copy_permissions_from(source_collection):
                 http_status = status.HTTP_400_BAD_REQUEST
-                response = {'detail': _("Source and destination objects don't "
-                                        "seem to have the same type")}
+                response = {
+                    'detail': _(
+                        "Source and destination objects don't "
+                        "seem to have the same type"
+                    )
+                }
                 return Response(response, status=http_status)
         else:
             raise exceptions.PermissionDenied()