DomPlugin: Use reflection to get fields from PHP 8.1

Author: jnvsor

build/kint.phar

@@ -55,11 +55,12 @@
 use Kint\Value\Representation\ContainerRepresentation;
 use Kint\Value\StringValue;
 use LogicException;
+use ReflectionClass;
 
 class DomPlugin extends AbstractPlugin implements PluginBeginInterface
 {
     /**
-     * Reflection doesn't work below 8.1, also it won't show readonly status.
+     * Reflection doesn't show readonly status.
      *
      * In order to ensure this is stable enough we're only going to provide
      * properties for element and node. If subclasses like attr or document
@@ -104,10 +105,7 @@ class DomPlugin extends AbstractPlugin implements PluginBeginInterface
         'innerHTML' => false,
         'outerHTML' => true,
         'substitutedNodeValue' => false,
-    ];
-
-    public const DOM_NS_VERSIONS = [
-        'outerHTML' => KINT_PHP85,
+        'children' => true,
     ];
 
     /**
@@ -208,6 +206,9 @@ class DomPlugin extends AbstractPlugin implements PluginBeginInterface
      */
     public static bool $verbose = false;
 
+    /** @psalm-var array<class-string, array<string, bool>> cache of properties for getKnownProperties */
+    protected static array $property_cache = [];
+
     protected ClassMethodsPlugin $methods_plugin;
     protected ClassStaticsPlugin $statics_plugin;
 
@@ -259,12 +260,14 @@ public function parseBegin(&$var, ContextInterface $c): ?AbstractValue
     /** @psalm-param Node|DOMNode $var */
     private function parseProperty(object $var, string $prop, ContextInterface $c): AbstractValue
     {
-        if (!isset($var->{$prop})) {
+        // Suppress deprecation message
+        if (@!isset($var->{$prop})) {
             return new FixedWidthValue($c, null);
         }
 
         $parser = $this->getParser();
-        $value = $var->{$prop};
+        // Suppress deprecation message
+        @$value = $var->{$prop};
 
         if (\is_scalar($value)) {
             return $parser->parse($value, $c);
@@ -450,25 +453,42 @@ private function parseNode(object $var, ContextInterface $c): DomNodeValue
      */
     public static function getKnownProperties(object $var): array
     {
-        if ($var instanceof Node) {
-            $known_properties = self::NODE_PROPS;
-            if ($var instanceof Element) {
-                $known_properties += self::ELEMENT_PROPS;
-            }
-
-            if ($var instanceof Document) {
-                $known_properties['textContent'] = true;
-            }
+        if (KINT_PHP81) {
+            $r = new ReflectionClass($var);
+            $classname = $r->getName();
+
+            if (!isset(self::$property_cache[$classname])) {
+                self::$property_cache[$classname] = [];
+
+                foreach ($r->getProperties() as $prop) {
+                    if ($prop->isStatic()) {
+                        continue;
+                    }
+
+                    $declaring = $prop->getDeclaringClass()->getName();
+                    $name = $prop->name;
+
+                    if (\in_array($declaring, [Node::class, Element::class], true)) {
+                        $readonly = self::NODE_PROPS[$name] ?? self::ELEMENT_PROPS[$name];
+                    } elseif (\in_array($declaring, [DOMNode::class, DOMElement::class], true)) {
+                        $readonly = self::DOMNODE_PROPS[$name] ?? self::DOMELEMENT_PROPS[$name];
+                    } else {
+                        continue;
+                    }
+
+                    self::$property_cache[$classname][$prop->name] = $readonly;
+                }
 
-            if ($var instanceof Attr || $var instanceof CharacterData) {
-                $known_properties['nodeValue'] = false;
-            }
+                if ($var instanceof Document) {
+                    self::$property_cache[$classname]['textContent'] = true;
+                }
 
-            foreach (self::DOM_NS_VERSIONS as $key => $val) {
-                if (false === $val) {
-                    unset($known_properties[$key]); // @codeCoverageIgnore
+                if ($var instanceof Attr || $var instanceof CharacterData) {
+                    self::$property_cache[$classname]['nodeValue'] = false;
                 }
             }
+
+            $known_properties = self::$property_cache[$classname];
         } else {
             $known_properties = self::DOMNODE_PROPS;
             if ($var instanceof DOMElement) {

src/Parser/DomPlugin.php

@@ -1129,7 +1129,7 @@ private function getExpectedPropsCount(bool $old)
             ];
 
             if (KINT_PHP85) {
-                ++$expected_props['ELEMENT_PROPS'];
+                $expected_props['ELEMENT_PROPS'] += 2;
             }
         }