btrfs-progs: receive: don't use O_NOATIME to open stream for dumping

open() returns EPERM with O_NOATIME if the user isn't root, and the file is
owned by a different UID. Normally this isn't a problem as receiving a stream
involves BTRFS_IOC_TREE_SEARCH which requires root, but --dump is an
unprivileged operation.

Pull-request: #1024
Signed-off-by: Mark Harmstone <[email protected]>
Signed-off-by: David Sterba <[email protected]>

Author: maharmstone

cmds/receive.c

@@ -1783,7 +1783,12 @@ static int cmd_receive(const struct cmd_struct *cmd, int argc, char **argv)
 	tomnt = argv[optind];
 
 	if (fromfile[0]) {
-		receive_fd = open(fromfile, O_RDONLY | O_NOATIME);
+		int flags = O_RDONLY;
+
+		if (!dump)
+			flags |= O_NOATIME;
+
+		receive_fd = open(fromfile, flags);
 		if (receive_fd < 0) {
 			error("cannot open %s: %m", fromfile);
 			goto out;