Make RESTMapper in client cluster-aware #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
soumyadip007
approved these changes
Aug 27, 2024
pkg/kcp/wrappers.go
Outdated
| var mu sync.RWMutex | ||
| cache := expirable.NewLRU[logicalcluster.Path, meta.RESTMapper](1000, nil, time.Minute) | ||
| return func(ctx context.Context) (meta.RESTMapper, error) { | ||
| c, _ := kontext.ClusterFrom(ctx) |
There was a problem hiding this comment.
The error from kontext.ClusterFrom(ctx) is ignored (c, _ := kontext.ClusterFrom(ctx)). We may consider it.
c, err := kontext.ClusterFrom(ctx)
if err != nil {
// Handle error appropriately, perhaps returning a nil mapper with the error
return nil, err
}
There was a problem hiding this comment.
Noticed that the second return value is a boolean, not an error. Will add a comment.
|
@soumyadip007: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
0f36a17 to
be71e2c
Compare
sttts
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
4 times, most recently
from
61933e4 to
440ded2
Compare
sttts
changed the title
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
4 times, most recently
from
0874689 to
afafb15
Compare
|
/retest |
1 similar comment
|
/retest |
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
afafb15 to
2272adc
Compare
kcp-ci-bot
added
size/XL
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
4 times, most recently
from
c11bdf3 to
adffd80
Compare
kcp-ci-bot
added
size/L
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
adffd80 to
900a3c9
Compare
kcp-ci-bot
added
size/XL
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
900a3c9 to
8a658d8
Compare
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
8a658d8 to
ef8fdeb
Compare
mjudeikis
approved these changes
Sep 1, 2024
pkg/client/client.go
Outdated
| }, | ||
| scheme: options.Scheme, | ||
| mapper: options.Mapper, | ||
| } | ||
| mapperCache, err := lru.New[logicalcluster.Name, meta.RESTMapper](1000) |
There was a problem hiding this comment.
Would it make sense 1000 to create a global variable? If somebody wants to tune it, its possible this way?
|
LGTM label has been added. Git tree hash: 012e2b48af67a9a94da088abcc0ca6420e82eec7
|
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-cluster-aware-rest-mapper
branch
from
000384b to
83ac60c
Compare
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
|
/lgtm |
|
LGTM label has been added. Git tree hash: e5fbb599c01580fe2f73c6de2763b38d309d80f3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes discovery cluster-aware, i.e. the RESTMapper is instantiated per cluster and cached with an LRU cache.
This matters because currently the controller-runtime client is unusable on non-uniform virtual workspaces or even against kcp itself as a scoped client because the used REST mapper talks to the wildcard endpoint only.