Click handlers to pass MouseEvent?

[Mattk70]

While the region mouse event handlers (click/dblclick) pass the triggering mouse event, the equivalent handlers for wavesurfer and other plugins do not. It would be very useful to have access the the MouseEvent for all MouseEvent handlers.

[katspaugh]

Regions pass through the event because sometimes you might want to prevent the propagation of a click on a region to the waveform.

If you have a good use case in mind for other plugins'/wavesurfer's events too (I haven't seen requests for this yet), we can add it there as well.

[Mattk70]

Well, I guess I was thinking about using the WS event handlers like regular DOM event handlers. It's true, a few (maybe too many) hours head-banging later, that I can attach the listener to the container, and I'll have the event I want.

For the sake of developer usability - could you just add the events? Since they're all passed by reference, I'm not sure there's a cost to that?

[katspaugh]

I usually try not to add functionality “just because” as it increases the API surface layer which means documentation, maintenance and support. If there’s a good convincing use case which the current API cannot already accommodate, then we add it.