Show Options if wp-cli path is not set when Run Command actions is run #64

Author: junichi11

src/org/netbeans/modules/php/wordpress/WordPressActionsExtender.java

@@ -44,17 +44,14 @@
 import java.util.ArrayList;
 import java.util.List;
 import javax.swing.Action;
-import org.netbeans.modules.php.api.util.StringUtils;
 import org.netbeans.modules.php.spi.framework.PhpModuleActionsExtender;
 import org.netbeans.modules.php.spi.framework.actions.RunCommandAction;
-import org.netbeans.modules.php.wordpress.commands.WordPressCli;
 import org.netbeans.modules.php.wordpress.ui.actions.CreateChildThemeAction;
 import org.netbeans.modules.php.wordpress.ui.actions.CreatePermalinkHtaccessAction;
 import org.netbeans.modules.php.wordpress.ui.actions.CreatePluginAction;
 import org.netbeans.modules.php.wordpress.ui.actions.CreateThemeAction;
 import org.netbeans.modules.php.wordpress.ui.actions.RefreshCodeCompletionAction;
 import org.netbeans.modules.php.wordpress.ui.actions.WordPressRunCommandAction;
-import org.netbeans.modules.php.wordpress.ui.options.WordPressOptions;
 import org.openide.util.NbBundle;
 
 /**
@@ -71,15 +68,7 @@ public String getMenuName() {
 
     @Override
     public RunCommandAction getRunCommandAction() {
-        // If wp-cli path is invalid, run command action is not added to context menu.
-        String wpCliPath = WordPressOptions.getInstance().getWpCliPath();
-        if (StringUtils.isEmpty(wpCliPath)) {
-            return null;
-        }
-        String error = WordPressCli.validate(wpCliPath);
-        if (error != null) {
-            return null;
-        }
+        // wp-cli path is validated when the Run Command action is run
         return WordPressRunCommandAction.getInstance();
     }
 

src/org/netbeans/modules/php/wordpress/ui/actions/WordPressRunCommandAction.java

@@ -41,10 +41,16 @@
  */
 package org.netbeans.modules.php.wordpress.ui.actions;
 
+import org.netbeans.api.options.OptionsDisplayer;
 import org.netbeans.modules.php.api.phpmodule.PhpModule;
+import org.netbeans.modules.php.api.util.StringUtils;
 import org.netbeans.modules.php.spi.framework.actions.RunCommandAction;
 import org.netbeans.modules.php.wordpress.WordPressPhpProvider;
+import org.netbeans.modules.php.wordpress.commands.WordPressCli;
+import org.netbeans.modules.php.wordpress.ui.options.WordPressOptions;
 import org.netbeans.modules.php.wordpress.util.WPUtils;
+import org.openide.DialogDisplayer;
+import org.openide.NotifyDescriptor;
 import org.openide.util.NbBundle;
 
 /**
@@ -54,6 +60,7 @@
 public class WordPressRunCommandAction extends RunCommandAction {
 
     private static final WordPressRunCommandAction INSTANCE = new WordPressRunCommandAction();
+    private static final long serialVersionUID = 158739462398606689L;
 
     private WordPressRunCommandAction() {
     }
@@ -67,6 +74,16 @@ public void actionPerformed(PhpModule phpModule) {
         if (!WPUtils.isWP(phpModule)) {
             return;
         }
+        String wpCliPath = WordPressOptions.getInstance().getWpCliPath();
+        if (StringUtils.isEmpty(wpCliPath)) {
+            openOptionsPanel(Bundle.WordPressRunCommandAction_message_no_wp_cli());
+            return;
+        }
+        String error = WordPressCli.validate(wpCliPath);
+        if (error != null) {
+            openOptionsPanel(Bundle.WordPressRunCommandAction_message_invalid_wp_cli());
+            return;
+        }
         WordPressPhpProvider.getInstance().getFrameworkCommandSupport(phpModule).openPanel();
     }
 
@@ -79,4 +96,17 @@ protected String getFullName() {
         return Bundle.WordPressRunCommandAction_name(getPureName());
     }
 
+    @NbBundle.Messages({
+        "WordPressRunCommandAction.message.no.wp-cli=Please set wp-cli path.",
+        "WordPressRunCommandAction.message.invalid.wp-cli=Please set valid wp-cli path."
+    })
+    private void openOptionsPanel(String errorMessage) {
+        NotifyDescriptor.Message message = new NotifyDescriptor.Message(
+                errorMessage,
+                NotifyDescriptor.ERROR_MESSAGE
+        );
+        DialogDisplayer.getDefault().notify(message);
+        OptionsDisplayer.getDefault().open(WordPressOptions.getOptionsPath());
+    }
+
 }

src/org/netbeans/modules/php/wordpress/ui/options/WordPressOptions.java

@@ -70,7 +70,7 @@ private WordPressOptions() {
     }
 
     public static String getOptionsPath() {
-        return UiUtils.OPTIONS_PATH + "/" + WordPressOptions.OPTIONS_SUBPATH; // NOI18N
+        return UiUtils.FRAMEWORKS_AND_TOOLS_OPTIONS_PATH + "/" + WordPressOptions.OPTIONS_SUBPATH; // NOI18N
     }
 
     public static WordPressOptions getInstance() {