Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Consider re-naming pageLoading() parameters #1389

Closed
@jscheel

Description

@jscheel

calling pageLoading(true) to hide the page loading dialog is not intuitive at all. It should instead be pageLoading(true) to show it and pageLoading(false) to hide it. I haven't looked at the code, but if you are using true because it's returning a value somewhere that you just pass straight into the call, just call pageLoading(!val)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions