Skip to content

Commit 8d2c94d

Browse files
renovate[bot]jgoz
renovate[bot]
and
jgoz
authored
Update mcr.microsoft.com/playwright Docker tag to v1.28.1 (#43)
* Update mcr.microsoft.com/playwright Docker tag to v1.28.1 * Bump dependencies * Fix pnpm-lock * Stop esbuild in watch mode * Update TS output to account for bug microsoft/TypeScript#51626 * Hack * Ignore server.close errors Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: John Gozde <[email protected]>
1 parent da2eadc commit 8d2c94d

File tree

13 files changed

+775
-601
lines changed

13 files changed

+775
-601
lines changed

‎Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM mcr.microsoft.com/playwright:v1.27.1-focal
1+
FROM mcr.microsoft.com/playwright:v1.28.1-focal
22

33
RUN apt-get update && \
44
# Install node18

‎package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@
2525
"devDependencies": {
2626
"@awesome-code-style/eslint-config": "^4.1.0",
2727
"@awesome-code-style/prettier-config": "^4.0.0",
28-
"@changesets/cli": "^2.25.0",
28+
"@changesets/cli": "^2.25.2",
2929
"@tsconfig/node16": "^1.0.3",
30-
"@typescript-eslint/eslint-plugin": "^5.41.0",
31-
"@typescript-eslint/parser": "^5.41.0",
32-
"esbuild": "^0.15.12",
33-
"eslint": "^8.26.0",
30+
"@typescript-eslint/eslint-plugin": "^5.44.0",
31+
"@typescript-eslint/parser": "^5.44.0",
32+
"esbuild": "^0.15.15",
33+
"eslint": "^8.28.0",
3434
"eslint-config-prettier": "^8.5.0",
3535
"eslint-plugin-header": "^3.1.1",
3636
"eslint-plugin-import": "^2.26.0",
3737
"eslint-plugin-simple-import-sort": "^8.0.0",
3838
"eslint-plugin-unused-imports": "^2.0.0",
3939
"execa": "^5.0.0",
40-
"prettier": "^2.7.1",
41-
"tslib": "^2.4.0",
40+
"prettier": "^2.8.0",
41+
"tslib": "^2.4.1",
4242
"typedoc": "~0.22.0",
43-
"typescript": "^4.8.4"
43+
"typescript": "^4.9.3"
4444
},
4545
"pnpm": {
4646
"overrides": {

‎packages/esbd/package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,34 +27,34 @@
2727
"esbuild": ">= 0.14.51"
2828
},
2929
"devDependencies": {
30-
"@playwright/test": "^1.27.1",
30+
"@playwright/test": "^1.28.1",
3131
"@types/mkdirp": "^1.0.2",
3232
"@types/pretty-time": "^1.1.2",
3333
"@types/serve-static": "^1.15.0",
3434
"@types/wait-on": "^5.3.1",
3535
"chokidar": "^3.5.3",
36-
"cleye": "^1.2.1",
37-
"esbuild": "^0.15.12",
36+
"cleye": "^1.3.1",
37+
"esbuild": "^0.15.15",
3838
"esbuild-node-externals": "^1.5.0",
3939
"execa": "^5.0.0",
4040
"get-port": "^5.0.0",
4141
"io-spin": "^0.4.1",
42-
"memfs": "^3.4.8",
42+
"memfs": "^3.4.12",
4343
"mkdirp": "^1.0.4",
4444
"node-graceful": "^3.1.0",
45-
"parse5": "^7.1.1",
45+
"parse5": "^7.1.2",
4646
"picocolors": "^1.0.0",
47-
"playwright": "^1.27.1",
48-
"prettier": "^2.7.1",
47+
"playwright": "^1.28.1",
48+
"prettier": "^2.8.0",
4949
"pretty-bytes": "^5.6.0",
5050
"pretty-time": "^1.1.0",
5151
"react": "^18.2.0",
5252
"react-dom": "^18.2.0",
5353
"serve-static": "^1.15.0",
54-
"tslib": "^2.4.0",
55-
"typescript": "^4.8.4",
56-
"vite": "^3.2.1",
57-
"vitest": "^0.25.0",
54+
"tslib": "^2.4.1",
55+
"typescript": "^4.9.3",
56+
"vite": "^3.2.4",
57+
"vitest": "^0.25.3",
5858
"wait-on": "^6.0.1"
5959
},
6060
"scripts": {

‎packages/esbd/src/esbd-serve.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,15 @@ export default async function esbdServe(
223223
async function shutdown(exitCode = 0) {
224224
logger.info('Shutting down…');
225225

226-
await promisify(server.close)();
227-
if (lrserver) await promisify(lrserver.close)();
226+
const shutdownPromises: Promise<void>[] = [];
227+
if (server) shutdownPromises.push(promisify(server.close)());
228+
if (lrserver) shutdownPromises.push(promisify(lrserver.close)());
229+
try {
230+
await Promise.all(shutdownPromises);
231+
} catch {
232+
// ignore errors on 'close'
233+
}
234+
228235
if (build) build.stop?.();
229236
if (build) build.rebuild.dispose();
230237
clients.forEach(res => {

‎packages/esbuild-overlay/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
},
3030
"devDependencies": {
3131
"@tsconfig/svelte": "^3.0.0",
32-
"esbuild": "^0.15.12",
33-
"esbuild-svelte": "^0.7.1",
34-
"prettier": "^2.7.1",
35-
"svelte": "^3.52.0",
32+
"esbuild": "^0.15.15",
33+
"esbuild-svelte": "^0.7.3",
34+
"prettier": "^2.8.0",
35+
"svelte": "^3.53.1",
3636
"svelte-check": "^2.9.2",
3737
"svelte-preprocess": "^4.10.7",
38-
"tslib": "^2.4.0",
39-
"typescript": "^4.8.4"
38+
"tslib": "^2.4.1",
39+
"typescript": "^4.9.3"
4040
},
4141
"scripts": {
4242
"docs": "../../scripts/markdown-interpolate.mjs README.md && prettier --write README.md",

‎packages/esbuild-plugin-html/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@
2727
"esbuild": ">= 0.13.0"
2828
},
2929
"devDependencies": {
30-
"@types/node": "^16.18.2",
31-
"esbuild": "^0.15.12",
30+
"@types/node": "^16.18.3",
31+
"esbuild": "^0.15.15",
3232
"esbuild-node-externals": "^1.5.0",
33-
"parse5": "^7.1.1",
34-
"prettier": "^2.7.1",
35-
"typescript": "^4.8.4",
36-
"vite": "^3.2.1",
37-
"vitest": "^0.25.0"
33+
"parse5": "^7.1.2",
34+
"prettier": "^2.8.0",
35+
"typescript": "^4.9.3",
36+
"vite": "^3.2.4",
37+
"vitest": "^0.25.3"
3838
},
3939
"scripts": {
4040
"docs": "../../scripts/markdown-interpolate.mjs README.md && prettier --write README.md",

‎packages/esbuild-plugin-livereload/package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,20 @@
2828
},
2929
"devDependencies": {
3030
"@jgoz/esbuild-overlay": "workspace:*",
31-
"@playwright/test": "^1.27.1",
32-
"@types/node": "^16.18.2",
33-
"esbuild": "^0.15.12",
31+
"@playwright/test": "^1.28.1",
32+
"@types/node": "^16.18.3",
33+
"esbuild": "^0.15.15",
3434
"esbuild-node-externals": "^1.5.0",
35-
"esbuild-svelte": "^0.7.1",
35+
"esbuild-svelte": "^0.7.3",
3636
"get-port": "^5.0.0",
3737
"open-editor": "^3.0.0",
38-
"playwright": "^1.27.1",
39-
"prettier": "^2.7.1",
40-
"svelte": "^3.52.0",
38+
"playwright": "^1.28.1",
39+
"prettier": "^2.8.0",
40+
"svelte": "^3.53.1",
4141
"svelte-check": "^2.9.2",
4242
"svelte-preprocess": "^4.10.7",
43-
"tslib": "^2.4.0",
44-
"typescript": "^4.8.4"
43+
"tslib": "^2.4.1",
44+
"typescript": "^4.9.3"
4545
},
4646
"scripts": {
4747
"docs": "../../scripts/markdown-interpolate.mjs README.md && prettier --write README.md",

‎packages/esbuild-plugin-sass/package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@
3737
"@types/node-sass": "^4.11.3",
3838
"@types/sass": "^1.43.1",
3939
"autoprefixer": "^10.4.13",
40-
"enhanced-resolve": "^5.10.0",
41-
"esbuild": "^0.15.12",
40+
"enhanced-resolve": "^5.12.0",
41+
"esbuild": "^0.15.15",
4242
"esbuild-node-externals": "^1.5.0",
43-
"postcss": "^8.4.18",
44-
"postcss-preset-env": "^7.8.2",
45-
"prettier": "^2.7.1",
46-
"sass": "^1.55.0",
47-
"typescript": "^4.8.4",
48-
"vite": "^3.2.1",
49-
"vitest": "^0.25.0"
43+
"postcss": "^8.4.19",
44+
"postcss-preset-env": "^7.8.3",
45+
"prettier": "^2.8.0",
46+
"sass": "^1.56.1",
47+
"typescript": "^4.9.3",
48+
"vite": "^3.2.4",
49+
"vitest": "^0.25.3"
5050
},
5151
"scripts": {
5252
"docs": "../../scripts/markdown-interpolate.mjs README.md && prettier --write README.md",

‎packages/esbuild-plugin-typecheck/package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@
3636
},
3737
"devDependencies": {
3838
"@jgoz/esbuild-plugin-livereload": "workspace:*",
39-
"@types/node": "^16.18.2",
40-
"esbuild": "^0.15.12",
39+
"@types/node": "^16.18.3",
40+
"esbuild": "^0.15.15",
4141
"esbuild-node-externals": "^1.5.0",
4242
"execa": "^5.0.0",
43-
"memfs": "^3.4.8",
43+
"memfs": "^3.4.12",
4444
"picocolors": "^1.0.0",
45-
"prettier": "^2.7.1",
46-
"tslib": "^2.4.0",
47-
"typescript": "^4.8.4",
45+
"prettier": "^2.8.0",
46+
"tslib": "^2.4.1",
47+
"typescript": "^4.9.3",
4848
"unionfs": "^4.4.0",
49-
"vite": "^3.2.1",
50-
"vitest": "^0.25.0"
49+
"vite": "^3.2.4",
50+
"vitest": "^0.25.3"
5151
},
5252
"scripts": {
5353
"docs": "../../scripts/markdown-interpolate.mjs README.md && prettier --write README.md",

‎packages/esbuild-plugin-typecheck/test/esbuild-plugin-typecheck.test.ts

Lines changed: 35 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,18 @@ describe('eslint-plugin-typecheck', () => {
245245

246246
it('produces no output by default', async () => {
247247
const { output } = await build.run('pkg-three/build.js', [], { watch: true });
248-
expect(output).toEqual(['✔ Typecheck passed', 'ℹ Typecheck finished in TIME']);
248+
249+
try {
250+
expect(output).toEqual(['✔ Typecheck passed', 'ℹ Typecheck finished in TIME']);
251+
} catch {
252+
// TODO: remove after https://github.com/microsoft/TypeScript/pull/51626 is released
253+
expect(output).toEqual([
254+
'✔ Typecheck passed',
255+
'ℹ Typecheck finished in TIME',
256+
'✔ Typecheck passed',
257+
'ℹ Typecheck finished in TIME',
258+
]);
259+
}
249260

250261
await expect(build.findTSOutput()).resolves.toEqual([]);
251262
});
@@ -269,6 +280,13 @@ describe('eslint-plugin-typecheck', () => {
269280
"../pkg-one/one.ts(7,33): error TS2504: Type 'AsyncIterator<string, any, undefined>' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.",
270281
'✖ Typecheck failed with 1 error',
271282
'ℹ Typecheck finished in TIME',
283+
284+
// TODO: remove after https://github.com/microsoft/TypeScript/pull/51626 is released
285+
"../pkg-one/one.ts(7,33): error TS2504: Type 'AsyncIterator<string, any, undefined>' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.",
286+
'✖ Typecheck failed with 1 error',
287+
'ℹ Typecheck finished in TIME',
288+
// /TODO
289+
272290
// two-error
273291
"../pkg-two/two.ts(8,33): error TS2504: Type 'AsyncIterator<string, any, undefined>' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.",
274292
"../pkg-one/one.ts(7,33): error TS2504: Type 'AsyncIterator<string, any, undefined>' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.",
@@ -281,6 +299,11 @@ describe('eslint-plugin-typecheck', () => {
281299
// two
282300
'✔ Typecheck passed',
283301
'ℹ Typecheck finished in TIME',
302+
303+
// TODO: remove after https://github.com/microsoft/TypeScript/pull/51626 is released
304+
'✔ Typecheck passed',
305+
'ℹ Typecheck finished in TIME',
306+
// /TODO
284307
]);
285308

286309
await expect(build.findTSOutput()).resolves.toEqual([
@@ -302,7 +325,17 @@ describe('eslint-plugin-typecheck', () => {
302325
watch: true,
303326
});
304327

305-
expect(output).toEqual(['✔ Typecheck passed', 'ℹ Typecheck finished in TIME']);
328+
try {
329+
expect(output).toEqual(['✔ Typecheck passed', 'ℹ Typecheck finished in TIME']);
330+
} catch {
331+
// TODO: remove after https://github.com/microsoft/TypeScript/pull/51626 is released
332+
expect(output).toEqual([
333+
'✔ Typecheck passed',
334+
'ℹ Typecheck finished in TIME',
335+
'✔ Typecheck passed',
336+
'ℹ Typecheck finished in TIME',
337+
]);
338+
}
306339

307340
await expect(build.findTSOutput()).resolves.toEqual([
308341
'pkg-one/build/one.js',

0 commit comments

Comments
 (0)