fix update escape fields

francescobianco · francescobianco · commit af792275fb30 · 2020-06-29T15:42:50.000+02:00
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "javanile/hamper",
     "description": "Developer friendly database library for vtiger",
-    "version": "0.0.3",
+    "version": "0.0.4",
     "license": "MIT",
     "type": "library",
     "authors": [
diff --git a/src/HamperDatabase.php b/src/HamperDatabase.php
@@ -268,7 +268,7 @@ public function update($table, $key, $data, $options = [])
             ));
         }
 
-        $fields = implode(' = ?,', array_keys($data)) . ' = ?';
+        $fields = '`' . implode('` = ?, `', array_keys($data)) . '` = ?';
         $params = array_merge(array_values($data), [$data[$key]]);
 
         $sql = "UPDATE `{$table}` SET {$fields} WHERE `{$key}` = ?";

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "javanile/hamper",`
`3`	`3`	`"description": "Developer friendly database library for vtiger",`
`4`		`- "version": "0.0.3",`
	`4`	`+ "version": "0.0.4",`
`5`	`5`	`"license": "MIT",`
`6`	`6`	`"type": "library",`
`7`	`7`	`"authors": [`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ public function update($table, $key, $data, $options = [])`
`268`	`268`	`));`
`269`	`269`	`}`
`270`	`270`
`271`		`- $fields = implode(' = ?,', array_keys($data)) . ' = ?';`
	`271`	+ $fields = '`' . implode('` = ?, `', array_keys($data)) . '` = ?';
`272`	`272`	`$params = array_merge(array_values($data), [$data[$key]]);`
`273`	`273`
`274`	`274`	$sql = "UPDATE `{$table}` SET {$fields} WHERE `{$key}` = ?";