Merge branch 'feature/79-original-suffix' of https://gitlab.com/Stefaan/importlib_resources

Author: jaraco

importlib_resources/_common.py

@@ -40,11 +40,11 @@ def fallback_resources(spec):
 
 
 @contextlib.contextmanager
-def _tempfile(reader):
+def _tempfile(reader, suffix=''):
     # Not using tempfile.NamedTemporaryFile as it leads to deeper 'try'
     # blocks due to the need to close the temporary file to work on Windows
     # properly.
-    fd, raw_path = tempfile.mkstemp()
+    fd, raw_path = tempfile.mkstemp(suffix=suffix)
     try:
         os.write(fd, reader())
         os.close(fd)
@@ -63,7 +63,7 @@ def as_file(path):
     Given a Traversable object, return that object as a
     path on the local file system in a context manager.
     """
-    with _tempfile(path.read_bytes) as local:
+    with _tempfile(path.read_bytes, suffix=path.name) as local:
         yield local
 
 

importlib_resources/_py3.py

@@ -161,7 +161,7 @@ def _path_from_reader(reader, resource):
         yield Path(reader.resource_path(norm_resource))
         return
     opener_reader = reader.open_resource(norm_resource)
-    with _common._tempfile(opener_reader.read) as res:
+    with _common._tempfile(opener_reader.read, suffix=norm_resource) as res:
         yield res
 
 

importlib_resources/tests/test_path.py

@@ -19,6 +19,7 @@ def test_reading(self):
         # Test also implicitly verifies the returned object is a pathlib.Path
         # instance.
         with resources.path(self.data, 'utf-8.file') as path:
+            self.assertTrue(path.name.endswith("utf-8.file"), repr(path))
             # pathlib.Path.read_text() was introduced in Python 3.5.
             with path.open('r', encoding='utf-8') as file:
                 text = file.read()