Skip to content

Fix release script broken by recent linting cleanup #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix release script broken by recent linting cleanup #4915

merged 1 commit into from
Nov 3, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Run bash scripts/package-deploy.sh
+ set -e
+ readonly VERSION
++ make echo-version
++ perl -lne 'print $1 if /^v(\d+.\d+.\d+)$/'
+ VERSION=1.51.0
scripts/package-deploy.sh: line 55: VERSION: readonly variable
Error: Process completed with exit code 1.

Description of the changes

  • remove readonly declaration

How was this change tested?

  • will rerun script after merging, no other way to test

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 3, 2023
@yurishkuro yurishkuro requested a review from a team as a code owner November 3, 2023 00:16
@yurishkuro yurishkuro requested a review from jkowall November 3, 2023 00:16
@yurishkuro yurishkuro merged commit 10e82c0 into jaegertracing:main Nov 3, 2023
@yurishkuro yurishkuro deleted the fix-release branch November 3, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro