Skip to content

Commit ffbcd21

Browse files
committed
improve ci & scripts
1 parent 21b81c6 commit ffbcd21

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

.github/workflows/ci-e2e-kafka.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@ jobs:
1818
fail-fast: false
1919
matrix:
2020
jaeger-version: [v1, v2]
21-
version:
22-
- major: 3.x
23-
distribution: kafka
24-
- major: 2.x
25-
distribution: kafka
26-
name: ${{ matrix.version.distribution}} ${{matrix.version.major }} ${{ matrix.jaeger-version }}
21+
kafka-version: ["3.x", "2.x"]
22+
name: kafka ${{matrix.kafka-version }} ${{ matrix.jaeger-version }}
2723
steps:
2824
- name: Harden Runner
2925
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
@@ -36,12 +32,12 @@ jobs:
3632
with:
3733
go-version: 1.23.x
3834

39-
- name: Run ${{ matrix.version.distribution }} integration tests
35+
- name: Run kafka integration tests
4036
id: test-execution
41-
run: bash scripts/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.version.major }}
37+
run: bash scripts/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }}
4238

4339
- name: Upload coverage to codecov
4440
uses: ./.github/actions/upload-codecov
4541
with:
4642
files: cover.out
47-
flags: ${{ matrix.version.distribution }}-${{ matrix.version.major }}-${{ matrix.version.jaeger }}
43+
flags: kafka-${{ matrix.kafka-version }}-${{ matrix.jaeger-version }}

scripts/kafka-integration-test.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
set -euf -o pipefail
77

8-
compose_file="docker-compose/kafka-integration-test/v3/docker-compose.yml"
8+
compose_file=""
99
jaeger_version=""
1010
kafka_version=""
1111
manage_kafka="true"
@@ -15,7 +15,7 @@ usage() {
1515
echo "Usage: $0 [-K] -j <jaeger_version> -v <kafka_version>"
1616
echo " -K: do not start or stop Kafka container (useful for local testing)"
1717
echo " -j: major version of Jaeger to test (v1|v2)"
18-
echo " -v: kafka major version, e.g: 3.9"
18+
echo " -v: kafka major version (3.9|2.8)"
1919
exit 1
2020
}
2121

@@ -33,7 +33,7 @@ parse_args() {
3333
jaeger_version=${OPTARG}
3434
;;
3535
v)
36-
kafka_version=${OPTARG}
36+
kafka_version=${OPTARG%%.*}
3737
;;
3838
K)
3939
manage_kafka="false"
@@ -47,7 +47,11 @@ parse_args() {
4747
echo "Error: Invalid Jaeger version. Valid options are v1 or v2"
4848
usage
4949
fi
50-
compose_file="docker-compose/kafka-integration-test/v${kafka_version%%.*}/docker-compose.yml"
50+
if [ "$kafka_version" != "3" ] && [ "$kafka_version" != "2" ]; then
51+
echo "Error: Invalid kafka version. Valid options are 3.x or 2.x"
52+
usage
53+
fi
54+
compose_file="docker-compose/kafka/v${kafka_version}/docker-compose.yml"
5155
}
5256

5357
setup_kafka() {

0 commit comments

Comments
 (0)