Skip to content

Commit f5268ed

Browse files
committed
increase coverage
Signed-off-by: Won Jun Jang <[email protected]>
1 parent afb6146 commit f5268ed

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

plugin/sampling/strategystore/factory_test.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,13 @@ func TestNewFactory(t *testing.T) {
4848

4949
// force the mock to return errors
5050
mock.retError = true
51-
assert.Error(t, f.Initialize(metrics.NullFactory, zap.NewNop()))
51+
assert.EqualError(t, f.Initialize(metrics.NullFactory, zap.NewNop()), "error initializing store")
5252
_, err = f.CreateStrategyStore()
53-
assert.Error(t, err)
53+
assert.EqualError(t, err, "error creating store")
54+
55+
f.StrategyStoreType = "nonsense"
56+
_, err = f.CreateStrategyStore()
57+
assert.EqualError(t, err, "No nonsense strategy store registered")
5458

5559
_, err = NewFactory(FactoryConfig{StrategyStoreType: "nonsense"})
5660
require.Error(t, err)
@@ -95,14 +99,14 @@ func (f *mockFactory) InitFromViper(v *viper.Viper) {
9599

96100
func (f *mockFactory) CreateStrategyStore() (ss.StrategyStore, error) {
97101
if f.retError {
98-
return nil, errors.New("error")
102+
return nil, errors.New("error creating store")
99103
}
100104
return nil, nil
101105
}
102106

103107
func (f *mockFactory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) error {
104108
if f.retError {
105-
return errors.New("error")
109+
return errors.New("error initializing store")
106110
}
107111
return nil
108112
}

0 commit comments

Comments
 (0)