Fix /qualitymetrics to return data in expected format (#6733)

## Which problem is this PR solving?
- Follow up to #6608
- Resolves #6607

## Description of the changes
- Remove intermediate `data:` element from the response
- Match response to what the UI expects
- Fix unit test that wasn't testing the output

## How was this change tested?
- unit tests
- manual test with jaegertracing/jaeger-ui#2641

---------

Signed-off-by: Yuri Shkuro <[email protected]>

Author: yurishkuro

cmd/query/app/http_handler.go

@@ -557,9 +557,5 @@ func spanNameHandler(spanName string, handler http.Handler) http.Handler {
 
 func (aH *APIHandler) getQualityMetrics(w http.ResponseWriter, r *http.Request) {
 	data := qualitymetrics.GetSampleData()
-	structuredRes := structuredResponse{
-		Data:   data,
-		Errors: []structuredError{},
-	}
-	aH.writeJSON(w, r, &structuredRes)
+	aH.writeJSON(w, r, &data)
 }

cmd/query/app/http_handler_test.go

@@ -31,6 +31,7 @@ import (
 	"go.uber.org/zap/zaptest/observer"
 
 	"github.com/jaegertracing/jaeger-idl/model/v1"
+	"github.com/jaegertracing/jaeger/cmd/query/app/qualitymetrics"
 	"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
 	"github.com/jaegertracing/jaeger/internal/storage/metricstore/disabled"
 	metricsmocks "github.com/jaegertracing/jaeger/internal/storage/v1/api/metricstore/mocks"
@@ -870,8 +871,9 @@ func TestGetQualityMetrics(t *testing.T) {
 	handler.getQualityMetrics(rr, req)
 	assert.Equal(t, http.StatusOK, rr.Code)
 	assert.Equal(t, "application/json", rr.Header().Get("Content-Type"))
-	var resp structuredResponse
-	assert.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp), "unable to unmarshal response")
+	var resp qualitymetrics.TQualityMetrics
+	require.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
+	require.Contains(t, resp.TraceQualityDocumentationLink, "github.com/jaegertracing")
 }
 
 func TestMetricsReaderError(t *testing.T) {