address

Signed-off-by: Won Jun Jang <[email protected]>

Author: black-adder

plugin/sampling/strategystore/static/factory_test.go

@@ -32,7 +32,7 @@ var _ plugin.Configurable = new(Factory)
 func TestFactory(t *testing.T) {
 	f := NewFactory()
 	v, command := config.Viperize(f.AddFlags)
-	command.ParseFlags([]string{"--sampling.strategies=fixtures/strategies.json"})
+	command.ParseFlags([]string{"--sampling.strategies-file=fixtures/strategies.json"})
 	f.InitFromViper(v)
 
 	assert.NoError(t, f.Initialize(metrics.NullFactory, zap.NewNop()))

plugin/sampling/strategystore/static/options.go

@@ -21,7 +21,7 @@ import (
 )
 
 const (
-	samplingStrategies = "sampling.strategies"
+	samplingStrategiesFile = "sampling.strategies-file"
 )
 
 // Options holds configuration for the static sampling strategy store.
@@ -32,11 +32,11 @@ type Options struct {
 
 // AddFlags adds flags for Options
 func AddFlags(flagSet *flag.FlagSet) {
-	flagSet.String(samplingStrategies, "", "The path for the sampling strategies file in JSON format")
+	flagSet.String(samplingStrategiesFile, "", "The path for the sampling strategies file in JSON format")
 }
 
 // InitFromViper initializes Options with properties from viper
 func (opts *Options) InitFromViper(v *viper.Viper) *Options {
-	opts.StrategiesFile = v.GetString(samplingStrategies)
+	opts.StrategiesFile = v.GetString(samplingStrategiesFile)
 	return opts
 }