helm conformance chart (#825)

Signed-off-by: Srinivasan Parthasarathy <[email protected]>

Author: sriumcp

helm/conformance/Chart.yaml

@@ -1,23 +1,5 @@
 apiVersion: v2
 name: conformance
 description: A Helm chart for Iter8 conformance experiment
-
-# A chart can be either an 'application' or a 'library' chart.
-#
-# Application charts are a collection of templates that can be packaged into versioned archives
-# to be deployed.
-#
-# Library charts provide useful utilities or functions for the chart developer. They're included as
-# a dependency of application charts to inject those utilities and functions into the rendering
-# pipeline. Library charts do not define any templates and therefore cannot be deployed.
 type: application
-
-# This is the chart version. This version number should be incremented each time you make changes
-# to the chart and its templates, including the app version.
-# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
-
-# This is the version number of the application being deployed. This version number should be
-# incremented each time you make changes to the application. Versions are not expected to
-# follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 0.1.0
+version: 0.1.0

helm/conformance/templates/experiment.yaml

@@ -1,21 +1,21 @@
 apiVersion: iter8.tools/v2alpha2
 kind: Experiment
 metadata:
-  name: codeengine-experiment
+  name: my-experiment
 spec:
   # target identifies the knative service under experimentation using its fully qualified name
-  target: codeengine-application
+  target: my-app
   strategy:
     # this experiment will perform a canary test
     testingPattern: Conformance
     actions:
       start:
       - task: metrics/collect
         with:
-          time: {{ .Values.Time }}
+          time: {{ .Values.Time | quote }}
           versions:
           - name: my-app
-            url: {{ .Values.URL }}
+            url: {{ .Values.URL | quote }}
             qps: {{ .Values.QPS }}
   criteria:
     requestCount: iter8-system/request-count
@@ -24,13 +24,13 @@ spec:
     objectives:
     - metric: iter8-system/mean-latency
       # 1 second mean latency is acceptable
-      upperLimit: {{ .Values.LimitMeanLatency }}
+      upperLimit: {{ .Values.LimitMeanLatency | quote }}
     - metric: iter8-system/error-rate
       # 2% error rate is acceptable
-      upperLimit: {{ .Values.LimitErrorRate }}
+      upperLimit: {{ .Values.LimitErrorRate | quote }}
     - metric: iter8-system/latency-95th-percentile
       # 3 second 95th percentile tail latency is acceptable
-      upperLimit: {{ .Values.Limit95thPercentileLatency }} 
+      upperLimit: {{ .Values.Limit95thPercentileLatency | quote }} 
   duration:
     intervalSeconds: 1
     iterationsPerLoop: 1

helm/conformance/values.yaml

@@ -1,21 +1,19 @@
 # Default values for Iter8 conformance experiment.
-# This is a YAML-formatted file.
-# Declare variables to be passed into your templates.
 
 # URL of the code engine application for which this conformance test is performed
 URL: https://example.com
 
 # How long will Iter8 collect metrics
-Time: "5s"
+Time: 5s
 
 # Queries per second used by Iter8 for collecting metrics
 QPS: 8.0
 
 # Upper limit on the mean latency. Values beyond this limit are not acceptable
-LimitMeanLatency: '"1000.0"' # 1 second latency on an average is ok. Not more.
+LimitMeanLatency: 1000.0 # 1 second latency on an average is ok. Not more.
 
 # Upper limit on the error rate. Values beyond this limit are not acceptable
-LimitErrorRate: '"0.02"' # 2% error rate is ok. Not more.
+LimitErrorRate: 0.02 # 2% error rate is ok. Not more.
 
 # Upper limit on the 95th percentile tail latency. Values beyond this limit are not acceptable
-Limit95thPercentileLatency: '"3000.0"' # 3 second tail latency on an average is ok. Not more.
+Limit95thPercentileLatency: 3000.0 # 3 second tail latency on an average is ok. Not more.