fix: verify public key exists in validator (#21)

Author: jacobheun

src/index.js

@@ -193,7 +193,12 @@ const extractPublicKey = (peerId, entry, callback) => {
     }
     return callback(null, pubKey)
   }
-  callback(null, peerId.pubKey)
+
+  if (peerId.pubKey) {
+    callback(null, peerId.pubKey)
+  } else {
+    callback(Object.assign(new Error('no public key is available'), { code: ERRORS.ERR_UNDEFINED_PARAMETER }))
+  }
 }
 
 // rawStdEncoding with RFC4648

test/index.spec.js

@@ -256,6 +256,25 @@ describe('ipns', function () {
     })
   })
 
+  it('validator with no valid public key should error', (done) => {
+    const sequence = 0
+    const validity = 1000000
+
+    ipns.create(rsa, cid, sequence, validity, (err, entry) => {
+      expect(err).to.not.exist()
+
+      const marshalledData = ipns.marshal(entry)
+      const key = Buffer.from(`/ipns/${ipfsId.id}`)
+
+      ipns.validator.validate(marshalledData, key, (err, valid) => {
+        expect(err).to.exist()
+        expect(err.code).to.eql(ERRORS.ERR_UNDEFINED_PARAMETER)
+        expect(valid).to.not.exist()
+        done()
+      })
+    })
+  })
+
   it('should use validator.validate to validate a record', (done) => {
     const sequence = 0
     const validity = 1000000