-
Notifications
You must be signed in to change notification settings - Fork 0
Open
inveniosoftware/invenio-cli
#390Description
The package-lock.json
file is not included in my-site
folder, and builds are not fully reproducible, as the JS dependencies are always re-locked.
Possible solution
- always copy
package-lock.json
from../var/instance/assets/
tomy-site/
. Make sure thatgit
ignores the creation/modification file dates if the file content didn't change - have an extra CLI param in
invenio-cli
that will:- copy the
package-lock.json
frommy-site
to../var/instance/assets/
- if the
my-site/pipfile.lock
is newer thanmy-site/package-lock.json
, then overwrite or fail (some python deps might have changed) - run
npm ci
instead ofnpm install
- copy the
- the development workflow with linked editable (watched) modules should be tested, to ensure nothing breaks
- when in
NODE_ENV=production
, the above should always happen. When inNODE_ENV=dev
, the I can use a new paraminvenio-cli install --keep-deps
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Triage