Skip to content

Commit 7063d31

Browse files
authored
Refs #35303 -- Made small optimizations in alogout() and aget_user().
In alogout(), there is no need to check the is_authenticated attribute when user is None. In aget_user(), there is no need to call get_session_auth_hash() twice. Follow up to 50f89ae.
1 parent cd7554e commit 7063d31

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

django/contrib/auth/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,8 @@ async def alogout(request):
269269
user = getattr(request, "auser", None)
270270
if user is not None:
271271
user = await user()
272-
if not getattr(user, "is_authenticated", True):
273-
user = None
272+
if not getattr(user, "is_authenticated", True):
273+
user = None
274274
await user_logged_out.asend(sender=user.__class__, request=request, user=user)
275275
await request.session.aflush()
276276
if hasattr(request, "auser"):
@@ -364,8 +364,8 @@ async def aget_user(request):
364364
session_hash_verified = False
365365
else:
366366
session_auth_hash = user.get_session_auth_hash()
367-
session_hash_verified = session_hash and constant_time_compare(
368-
session_hash, user.get_session_auth_hash()
367+
session_hash_verified = constant_time_compare(
368+
session_hash, session_auth_hash
369369
)
370370
if not session_hash_verified:
371371
# If the current secret does not verify the session, try

0 commit comments

Comments
 (0)