feat: Remove redundant error creation, remove redundant check for Dropped

Author: devanbenz

tsdb/field_validator.go

@@ -43,12 +43,15 @@ func ValidateAndCreateFields(mf *MeasurementFields, point models.Point, skipSize
 		fieldKey := iter.FieldKey()
 		// Skip fields name "time", they are illegal.
 		if bytes.Equal(fieldKey, TimeBytes) {
-			partialWriteError = &PartialWriteError{
-				Reason: fmt.Sprintf(
-					"invalid field name: input field \"%[1]s\" on measurement \"%s\" is invalid. Field \"%[1]s\" has been stripped from point.",
-					string(fieldKey), string(point.Name())),
-				Dropped: 0,
+			if partialWriteError == nil {
+				partialWriteError = &PartialWriteError{
+					Reason: fmt.Sprintf(
+						"invalid field name: input field \"%[1]s\" on measurement \"%s\" is invalid. Field \"%[1]s\" has been stripped from point.",
+						fieldKey, point.Name()),
+					Dropped: 0,
+				}
 			}
+
 			continue
 		}
 

tsdb/shard.go

@@ -725,7 +725,7 @@ func (s *Shard) validateSeriesAndFields(points []models.Point, tracker StatsTrac
 			continue
 			// Sometimes we will drop fields like 'time' but not an entire point
 			// we want to inform the writer that something occurred.
-		} else if partialWriteError != nil && partialWriteError.Dropped <= 0 {
+		} else if partialWriteError != nil {
 			partialWriteError.Database = s.Database()
 			partialWriteError.RetentionPolicy = s.RetentionPolicy()
 			err = *partialWriteError