feat: Export TimeBytes from tsdb, remove check that wasn't needed

Author: devanbenz

tsdb/engine/tsm1/engine.go

@@ -64,7 +64,6 @@ var (
 	// Ensure Engine implements the interface.
 	_ tsdb.Engine = &Engine{}
 	// Static objects to prevent small allocs.
-	timeBytes              = []byte("time")
 	keyFieldSeparatorBytes = []byte(keyFieldSeparator)
 	emptyBytes             = []byte{}
 )
@@ -1360,11 +1359,6 @@ func (e *Engine) WritePoints(points []models.Point, tracker tsdb.StatsTracker) e
 		npoints++
 		var nValuesForPoint int64
 		for iter.Next() {
-			// Skip fields name "time", they are illegal
-			if bytes.Equal(iter.FieldKey(), timeBytes) {
-				continue
-			}
-
 			keyBuf = append(keyBuf[:baseLen], iter.FieldKey()...)
 
 			if e.seriesTypeMap != nil {

tsdb/field_validator.go

@@ -42,11 +42,11 @@ func ValidateAndCreateFields(mf *MeasurementFields, point models.Point, skipSize
 
 		fieldKey := iter.FieldKey()
 		// Skip fields name "time", they are illegal.
-		if bytes.Equal(fieldKey, timeBytes) {
+		if bytes.Equal(fieldKey, TimeBytes) {
 			partialWriteError = &PartialWriteError{
 				Reason: fmt.Sprintf(
-					"invalid field name: input field \"%s\" on measurement \"%s\" is invalid. Field \"%s\" has been stripped from point.",
-					"time", string(point.Name()), "time"),
+					"invalid field name: input field \"%[1]s\" on measurement \"%s\" is invalid. Field \"%[1]s\" has been stripped from point.",
+					string(fieldKey), string(point.Name())),
 				Dropped: 0,
 			}
 			continue

tsdb/shard.go

@@ -88,7 +88,7 @@ var (
 
 var (
 	// Static objects to prevent small allocs.
-	timeBytes = []byte("time")
+	TimeBytes = []byte("time")
 )
 
 // A ShardError implements the error interface, and contains extra
@@ -631,7 +631,7 @@ func (s *Shard) validateSeriesAndFields(points []models.Point, tracker StatsTrac
 		tags := p.Tags()
 
 		// Drop any series w/ a "time" tag, these are illegal
-		if v := tags.Get(timeBytes); v != nil {
+		if v := tags.Get(TimeBytes); v != nil {
 			dropped++
 			if reason == "" {
 				reason = fmt.Sprintf(
@@ -689,7 +689,7 @@ func (s *Shard) validateSeriesAndFields(points []models.Point, tracker StatsTrac
 		iter := p.FieldIterator()
 		validField := false
 		for iter.Next() {
-			if bytes.Equal(iter.FieldKey(), timeBytes) {
+			if bytes.Equal(iter.FieldKey(), TimeBytes) {
 				continue
 			}
 			validField = true