Skip to content

Commit b7fab9b

Browse files
reckenrodeindygreg
authored andcommitted
apple-codesign: honor verbose level to set logging level
Using `from_env` was only setting the logging level from the environment. Setting `filter_level` then using `parse_default_env` sets the logging level based on the verbosity level while still honoring the `RUST_LOG` environment variable. Closes #162.
1 parent cfb7529 commit b7fab9b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

apple-codesign/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
Released on ReleaseDate.
88

9+
* Fixed `env_logger` construction so `RUST_LOG` environment variable is
10+
respected. (#162)
911
* MSRV 1.70 -> 1.78.
1012
* `aws-config` 1.1 -> 1.5.
1113
* `aws-sdk-s3` 1.12 -> 1.24.

apple-codesign/src/cli/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2499,9 +2499,11 @@ pub fn main_impl() -> Result<(), AppleCodesignError> {
24992499
_ => LevelFilter::Trace,
25002500
};
25012501

2502-
let mut builder = env_logger::Builder::from_env(
2503-
env_logger::Env::default().default_filter_or(log_level.as_str()),
2504-
);
2502+
let mut builder = env_logger::Builder::new();
2503+
2504+
builder
2505+
.filter_level(log_level)
2506+
.parse_default_env();
25052507

25062508
// Disable log context except at higher log levels.
25072509
if log_level <= LevelFilter::Info {

0 commit comments

Comments
 (0)