fix: remove lingering DOM elements on destroy() (#291)

Author: vetruvet

src/js/Drift.js

@@ -168,6 +168,7 @@ export default class Drift {
   }
 
   destroy() {
+    this.trigger._hide();
     this.trigger._unbindEvents();
   }
 }

src/js/Trigger.js

@@ -121,7 +121,9 @@ export default class Trigger {
   }
 
   _hide(e) {
-    e.preventDefault();
+    if (e) {
+      e.preventDefault();
+    }
 
     this._lastMovement = null;
 

test/testDrift.js

@@ -1,4 +1,4 @@
-/* global describe it expect beforeEach afterEach */
+/* global describe it expect beforeEach afterEach spyOn */
 
 import Drift from "../src/js/Drift";
 
@@ -137,5 +137,20 @@ describe("Drift", () => {
         expect(drift.trigger.enabled).toBe(false);
       });
     });
+
+    describe("#destroy", () => {
+      it("should hide and unbind events", function() {
+        const anchor = document.querySelector(".test-anchor");
+        const drift = new Drift(anchor);
+
+        const hideSpy = spyOn(drift.trigger, "_hide");
+        const unbindEventsSpy = spyOn(drift.trigger, "_unbindEvents");
+
+        drift.destroy();
+
+        expect(hideSpy).toHaveBeenCalled();
+        expect(unbindEventsSpy).toHaveBeenCalled();
+      });
+    });
   });
 });