Skip to content

Commit d546ce1

Browse files
sisco0luqven
authored andcommitted
fix: remove optional eventlistener parameters
refs: #647
1 parent 9fc3569 commit d546ce1

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

src/js/Trigger.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -74,35 +74,35 @@ export default class Trigger {
7474
}
7575

7676
_bindEvents() {
77-
this.settings.el.addEventListener("mouseenter", this._handleEntry, false);
78-
this.settings.el.addEventListener("mouseleave", this._hide, false);
79-
this.settings.el.addEventListener("mousemove", this._handleMovement, false);
77+
this.settings.el.addEventListener("mouseenter", this._handleEntry);
78+
this.settings.el.addEventListener("mouseleave", this._hide);
79+
this.settings.el.addEventListener("mousemove", this._handleMovement);
8080

8181
const isPassive = { passive: this.settings.passive };
8282
if (this.settings.handleTouch) {
8383
this.settings.el.addEventListener("touchstart", this._handleEntry, isPassive);
84-
this.settings.el.addEventListener("touchend", this._hide, false);
84+
this.settings.el.addEventListener("touchend", this._hide);
8585
this.settings.el.addEventListener("touchmove", this._handleMovement, isPassive);
8686
} else {
8787
this.settings.el.addEventListener("touchstart", this._preventDefault, isPassive);
88-
this.settings.el.addEventListener("touchend", this._preventDefault, false);
88+
this.settings.el.addEventListener("touchend", this._preventDefault);
8989
this.settings.el.addEventListener("touchmove", this._preventDefault, isPassive);
9090
}
9191
}
9292

9393
_unbindEvents() {
94-
this.settings.el.removeEventListener("mouseenter", this._handleEntry, false);
95-
this.settings.el.removeEventListener("mouseleave", this._hide, false);
96-
this.settings.el.removeEventListener("mousemove", this._handleMovement, false);
94+
this.settings.el.removeEventListener("mouseenter", this._handleEntry);
95+
this.settings.el.removeEventListener("mouseleave", this._hide);
96+
this.settings.el.removeEventListener("mousemove", this._handleMovement);
9797

9898
if (this.settings.handleTouch) {
99-
this.settings.el.removeEventListener("touchstart", this._handleEntry, false);
100-
this.settings.el.removeEventListener("touchend", this._hide, false);
101-
this.settings.el.removeEventListener("touchmove", this._handleMovement, false);
99+
this.settings.el.removeEventListener("touchstart", this._handleEntry);
100+
this.settings.el.removeEventListener("touchend", this._hide);
101+
this.settings.el.removeEventListener("touchmove", this._handleMovement);
102102
} else {
103-
this.settings.el.removeEventListener("touchstart", this._preventDefault, false);
104-
this.settings.el.removeEventListener("touchend", this._preventDefault, false);
105-
this.settings.el.removeEventListener("touchmove", this._preventDefault, false);
103+
this.settings.el.removeEventListener("touchstart", this._preventDefault);
104+
this.settings.el.removeEventListener("touchend", this._preventDefault);
105+
this.settings.el.removeEventListener("touchmove", this._preventDefault);
106106
}
107107
}
108108

src/js/ZoomPane.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,10 @@ export default class ZoomPane {
170170
}
171171

172172
_removeListenersAndResetClasses() {
173-
this.el.removeEventListener("animationend", this._completeShow, false);
174-
this.el.removeEventListener("animationend", this._completeHide, false);
175-
this.el.removeEventListener("webkitAnimationEnd", this._completeShow, false);
176-
this.el.removeEventListener("webkitAnimationEnd", this._completeHide, false);
173+
this.el.removeEventListener("animationend", this._completeShow);
174+
this.el.removeEventListener("animationend", this._completeHide);
175+
this.el.removeEventListener("webkitAnimationEnd", this._completeShow);
176+
this.el.removeEventListener("webkitAnimationEnd", this._completeHide);
177177
removeClasses(this.el, this.openClasses);
178178
removeClasses(this.el, this.closingClasses);
179179
}
@@ -186,7 +186,7 @@ export default class ZoomPane {
186186

187187
if (this.imgEl.getAttribute("src") != imageURL) {
188188
addClasses(this.el, this.loadingClasses);
189-
this.imgEl.addEventListener("load", this._handleLoad, false);
189+
this.imgEl.addEventListener("load", this._handleLoad);
190190
this._setImageURL(imageURL);
191191
}
192192

@@ -199,8 +199,8 @@ export default class ZoomPane {
199199
}
200200

201201
if (this.HAS_ANIMATION) {
202-
this.el.addEventListener("animationend", this._completeShow, false);
203-
this.el.addEventListener("webkitAnimationEnd", this._completeShow, false);
202+
this.el.addEventListener("animationend", this._completeShow);
203+
this.el.addEventListener("webkitAnimationEnd", this._completeShow);
204204
addClasses(this.el, this.openingClasses);
205205
}
206206
}
@@ -219,8 +219,8 @@ export default class ZoomPane {
219219
this.isShowing = false;
220220

221221
if (this.HAS_ANIMATION) {
222-
this.el.addEventListener("animationend", this._completeHide, false);
223-
this.el.addEventListener("webkitAnimationEnd", this._completeHide, false);
222+
this.el.addEventListener("animationend", this._completeHide);
223+
this.el.addEventListener("webkitAnimationEnd", this._completeHide);
224224
addClasses(this.el, this.closingClasses);
225225
} else {
226226
removeClasses(this.el, this.openClasses);
@@ -229,15 +229,15 @@ export default class ZoomPane {
229229
}
230230

231231
_completeShow() {
232-
this.el.removeEventListener("animationend", this._completeShow, false);
233-
this.el.removeEventListener("webkitAnimationEnd", this._completeShow, false);
232+
this.el.removeEventListener("animationend", this._completeShow);
233+
this.el.removeEventListener("webkitAnimationEnd", this._completeShow);
234234

235235
removeClasses(this.el, this.openingClasses);
236236
}
237237

238238
_completeHide() {
239-
this.el.removeEventListener("animationend", this._completeHide, false);
240-
this.el.removeEventListener("webkitAnimationEnd", this._completeHide, false);
239+
this.el.removeEventListener("animationend", this._completeHide);
240+
this.el.removeEventListener("webkitAnimationEnd", this._completeHide);
241241

242242
removeClasses(this.el, this.openClasses);
243243
removeClasses(this.el, this.closingClasses);
@@ -257,7 +257,7 @@ export default class ZoomPane {
257257
}
258258

259259
_handleLoad() {
260-
this.imgEl.removeEventListener("load", this._handleLoad, false);
260+
this.imgEl.removeEventListener("load", this._handleLoad);
261261
removeClasses(this.el, this.loadingClasses);
262262
}
263263
}

0 commit comments

Comments
 (0)