Fix wording and check for negative number of replicas.

manishrjain · manishrjain · commit f1803442ed8b · 2018-08-10T13:00:21.000-07:00
diff --git a/dgraph/cmd/zero/run.go b/dgraph/cmd/zero/run.go
@@ -141,10 +141,11 @@ func run() {
 		rebalanceInterval: Zero.Conf.GetDuration("rebalance_interval"),
 	}
 
-	if opts.numReplicas % 2 == 0 {
-		log.Fatalf("Invalid flag value --replicas=%d - number of replicas cannot be divisible by 2", opts.numReplicas)
+	if opts.numReplicas < 0 || opts.numReplicas%2 == 0 {
+		log.Fatalf("ERROR: Number of replicas must be odd for consensus. Found: %d",
+			opts.numReplicas)
 	}
-	
+
 	if Zero.Conf.GetBool("expose_trace") {
 		trace.AuthRequest = func(req *http.Request) (any, sensitive bool) {
 			return true, true

Original file line number	Diff line number	Diff line change
`@@ -141,10 +141,11 @@ func run() {`
`141`	`141`	`rebalanceInterval: Zero.Conf.GetDuration("rebalance_interval"),`
`142`	`142`	`}`
`143`	`143`
`144`		`- if opts.numReplicas % 2 == 0 {`
`145`		`- log.Fatalf("Invalid flag value --replicas=%d - number of replicas cannot be divisible by 2", opts.numReplicas)`
	`144`	`+ if opts.numReplicas < 0 \|\| opts.numReplicas%2 == 0 {`
	`145`	`+ log.Fatalf("ERROR: Number of replicas must be odd for consensus. Found: %d",`
	`146`	`+ opts.numReplicas)`
`146`	`147`	`}`
`147`		`-`
	`148`	`+`
`148`	`149`	`if Zero.Conf.GetBool("expose_trace") {`
`149`	`150`	`trace.AuthRequest = func(req *http.Request) (any, sensitive bool) {`
`150`	`151`	`return true, true`