fix: do not throw on missing metadata

Author: tpluscode

.changeset/witty-shirts-film.md

@@ -0,0 +1,5 @@
+---
+"@hydrofoil/shaperone-wc": patch
+---
+
+Do not throw when meta is missing

packages/core/models/editors/index.ts

@@ -31,7 +31,7 @@ export interface SingleEditorMatch extends SingleEditor {
   score: number | null
 }
 
-type EditorMap<T> = Record<string, T>
+type EditorMap<T> = Record<string, T | undefined>
 
 export interface EditorsState {
   metadata: AnyPointer

packages/core/models/editors/reducers/addMetadata.ts

@@ -9,13 +9,19 @@ type MultiEditors = EditorsState['multiEditors']
 type SingleEditors = EditorsState['singleEditors']
 
 function updateMeta<T>(metadata: AnyPointer) {
-  return (previousValue: T, [key, editor]: [string, Editor<EditorMatcher>]): T => ({
-    ...previousValue,
-    [key]: {
-      ...editor,
-      meta: new EditorMeta(metadata.node(editor.term)),
-    },
-  })
+  return (previousValue: T, [key, editor]: [string, Editor<EditorMatcher> | undefined]): T => {
+    if (!editor) {
+      return previousValue
+    }
+
+    return {
+      ...previousValue,
+      [key]: {
+        ...editor,
+        meta: new EditorMeta(metadata.node(editor.term)),
+      },
+    }
+  }
 }
 
 export function addMetadata(state: EditorsState, dataset: DatasetCore): EditorsState {

packages/core/models/forms/effects.ts

@@ -1,14 +1,26 @@
 import type { Store } from '../../state/index'
+import { Editor, MultiEditor, SingleEditor } from '../editors'
+
+function toDefined<T>(arr: T[], next: T | undefined): T[] {
+  if (!next) {
+    return arr
+  }
+
+  return [...arr, next]
+}
 
 export function effects(store: Store) {
   const dispatch = store.getDispatch()
 
   return {
     'editors/addMatchers': () => {
-      const { editors: { singleEditors, multiEditors } } = store.getState()
+      const { editors } = store.getState()
+      const singleEditors = Object.values(editors.singleEditors).reduce<Editor<SingleEditor>[]>(toDefined, [])
+      const multiEditors = Object.values(editors.multiEditors).reduce<Editor<MultiEditor>[]>(toDefined, [])
+
       dispatch.forms.setEditors({
-        singleEditors: [...Object.values(singleEditors)],
-        multiEditors: [...Object.values(multiEditors)],
+        singleEditors,
+        multiEditors,
       })
     },
   }

packages/core/test/models/editors/reducers/addMetadata.test.ts

@@ -50,9 +50,9 @@ describe('core/models/editors/reducers/addMetadata', () => {
     const after = addMetadata(before, dataset)
 
     // expect
-    expect(after.allEditors[ex.Foo.value].meta.label).to.eq('Foo editor')
-    expect(after.allEditors[ex.Bar.value].meta.label).to.eq('Bar editor')
-    expect(after.singleEditors[ex.Foo.value].meta.label).to.eq('Foo editor')
-    expect(after.singleEditors[ex.Bar.value].meta.label).to.eq('Bar editor')
+    expect(after.allEditors[ex.Foo.value]?.meta.label).to.eq('Foo editor')
+    expect(after.allEditors[ex.Bar.value]?.meta.label).to.eq('Bar editor')
+    expect(after.singleEditors[ex.Foo.value]?.meta.label).to.eq('Foo editor')
+    expect(after.singleEditors[ex.Bar.value]?.meta.label).to.eq('Bar editor')
   })
 })

packages/wc/DefaultRenderer.ts

@@ -67,7 +67,7 @@ export const DefaultRenderer: Renderer = {
             }
             const component = components[editor.value]
             if (!component) {
-              return html`No component found for ${editors.allEditors[editor.value].meta.label}`
+              return html`No component found for ${editors.allEditors[editor.value]?.meta.label || editor.value}`
             }
 
             if (!component.loaded) {
@@ -126,7 +126,7 @@ export const DefaultRenderer: Renderer = {
               }
               const component = components[editor.value]
               if (!component) {
-                return html`No component found for ${editors.allEditors[editor.value].meta.label}`
+                return html`No component found for ${editors.allEditors[editor.value]?.meta.label || editor.value}`
               }
 
               if (!component.loaded) {