Skip to content

Conversation

@pfi79
Copy link
Contributor

@pfi79 pfi79 commented Nov 2, 2025

  • added headers so that some sites skip the request rather than return a 403 error (yes, not for everyone, but I'll deal with this later)
  • site https://hyperledger-fabric.readthedocs.io / has a limit of 60 requests per minute, configured so that the number of requests does not exceed this limit. Error 429 on this site has gone away.
  • added exceptions so that the crawl takes place only in /en/latest/, because, for example, /zh-cn/latest/ is located in another repository.

Now it will be possible to work with it.:

  • handle 404 errors
  • handle 403 errors

@pfi79 pfi79 requested a review from a team as a code owner November 2, 2025 09:03
@pfi79 pfi79 force-pushed the broken-link-check branch from abd6ac6 to 9e64de6 Compare November 3, 2025 12:06
- added headers so that some sites skip the request rather than return a 403 error (yes, not for everyone, but I'll deal with this later)
- site https://hyperledger-fabric.readthedocs.io / has a limit of 60 requests per minute, configured so that the number of requests does not exceed this limit. Error 429 on this site has gone away.
- added exceptions so that the crawl takes place only in /en/latest/, because, for example, /zh-cn/latest/ is located in another repository.

Now it will be possible to work with it.:
- handle 404 errors
- handle 403 errors

Signed-off-by: Fedor Partanskiy <[email protected]>
@pfi79 pfi79 force-pushed the broken-link-check branch from 9e64de6 to 6a15fdb Compare November 3, 2025 12:08
@C0rWin
Copy link
Contributor

C0rWin commented Nov 3, 2025

Not sure whenever it should be fixed but CI fails with:

https://hyperledger-fabric.readthedocs.io/en/latest/whatis.html
	403	https://dl.acm.org/doi/10.1145/3190508.3190538
https://hyperledger-fabric.readthedocs.io/en/latest/status.html
	404	https://tsc.hyperledger.org/project-lifecycle.html
https://hyperledger-fabric.readthedocs.io/en/latest/deploy_chaincode.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/smartcontract.html
https://hyperledger-fabric.readthedocs.io/en/latest/write_first_app.html
	404	https://nodejs.dev/learn/how-to-install-nodejs
https://hyperledger-fabric.readthedocs.io/en/latest/orderer/ordering_service.html
	error when dialing 128.52.129.186:443: dial tcp 128.52.129.186:443: connect: connection refused	https://pmg.csail.mit.edu/papers/osdi99.pdf
https://hyperledger-fabric.readthedocs.io/en/latest/ledger/ledger.html
	403	http://www.sciencephoto.com/media/686227/view/accounting-ledger-sumerian-cuneiform
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/chaincodenamespace.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/chaincodenamespace.html#channels
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/developing_applications.html
https://hyperledger-fabric.readthedocs.io/en/latest/smartcontract/smartcontract.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/chaincodenamespace.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/chaincodenamespace.html#cross-chaincode-access
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/developing_applications.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/transactioncontext.html
https://hyperledger-fabric.readthedocs.io/en/latest/chaincode_lifecycle.html
	403	https://java.com/en/
https://hyperledger-fabric.readthedocs.io/en/latest/network/network.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/developing_applications.html
https://hyperledger-fabric.readthedocs.io/en/latest/international_languages.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/developing_applications.html
https://hyperledger-fabric.readthedocs.io/en/latest/chaincode4ade.html
	403	https://java.com/en/
	403	https://www.npmjs.com/package/json-stringify-deterministic
https://hyperledger-fabric.readthedocs.io/en/latest/commands/peerchaincode.html
	403	https://www.npmjs.com/package/fabric-contract-api
https://hyperledger-fabric.readthedocs.io/en/latest/commands/peerchaincode.html?%20chaincode%20query
	403	https://www.npmjs.com/package/fabric-contract-api
https://hyperledger-fabric.readthedocs.io/en/latest/docs_guide.html
	404	https://hyperledger-fabric.readthedocs.io/en/latest/developapps/developing_applications.html
	404	https://raw.githubusercontent.com/hyperledger/fabric/main/docs/source/developapps/developing_applications.rst

@pfi79
Copy link
Contributor Author

pfi79 commented Nov 4, 2025

Not sure whenever it should be fixed but CI fails with:

Yes, but it didn't work at all before, the 403 error was on the root page.

Initially, this pipe was added to identify non-working links and it always ended with an error.
I've made it work so far, but this is only the first step.
Next, I will bring it to the green state.

@pfi79 pfi79 merged commit acaf067 into hyperledger:main Nov 4, 2025
15 of 16 checks passed
@pfi79 pfi79 deleted the broken-link-check branch November 4, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants