change logger for unit test smartbft #5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedor Partanskiy <[email protected]>
yacovm
reviewed
Oct 7, 2024
| dir := t.TempDir() | ||
| channelId := "testchannel" | ||
|
|
||
| flogging.ActivateSpec("debug") |
Contributor
Author
There was a problem hiding this comment.
The default logs seem to be Info.
In case of failure I would like to see debug logs from the smartbft library
Contributor
There was a problem hiding this comment.
Why? the tests aren't flaky in CI
Contributor
Author
There was a problem hiding this comment.
like what's done here
and there's more than one place like this.
Contributor
Author
There was a problem hiding this comment.
Right. The TestAddAndRemoveNodeWithoutStop test is not stable. Quite often it terminates with an error. I can't catch the error and fix it yet.
yacovm
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are unit tests in smartbft, where some logs are written via logger and some via testing.Logf.
As a result, when the test terminates with an error. Some of the sequential logs are in one place, some in another.
I decided to bring the logs to a single view through the logger. In order to deal with the floating error in the future