Skip to content

Commit 7eea260

Browse files
committed
[FAB-7803] Extend doc to encourage CR reviews
This change adds a section encouraging potential contributors to help maintainers by reviewing open CRs. Patch-set #2: fix typo Patch-set #3: fix minor grammar stuff Change-Id: I7b0671cee14b1e453b73fc9c601b8994394aae50 Signed-off-by: Arnaud J Le Hors <[email protected]>
1 parent 4a0d551 commit 7eea260

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

docs/source/CONTRIBUTING.rst

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ If it has not been previously reported, create a new JIRA. Please try to provide
5858
sufficient information for someone else to reproduce the
5959
issue. One of the project's maintainers should respond to your issue within 24
6060
hours. If not, please bump the issue with a comment and request that it be
61-
reviewed. You can also post to the relevant fabric channel in
61+
reviewed. You can also post to the relevant Hyperledger Fabric channel in
6262
`Hyperledger Rocket Chat <https://chat.hyperledger.org>`__. For example, a doc bug should
6363
be broadcast to ``#fabric-documentation``, a database bug to ``#fabric-ledger``,
6464
and so on...
@@ -87,6 +87,25 @@ assignment if you cannot finish in a reasonable time, or add a comment
8787
saying that you are still actively working the issue if you need a
8888
little more time.
8989

90+
Reviewing submitted Change Requests (CRs)
91+
-----------------------------------------
92+
93+
Another way to contribute and learn about Hyperledgr Fabric is to help the
94+
maintainers with the review of the CRs that are open. Indeed
95+
maintainers have the difficult role of having to review all the CRs
96+
that are being submitted and evaluate whether they should be merged or
97+
not. You can review the code and/or documentation changes, test the
98+
changes, and tell the submitters and maintainers what you think. Once
99+
your review and/or test is complete just reply to the CR with your
100+
findings, by adding comments and/or voting. A comment saying something
101+
like "I tried it on system X and it works" or possibly "I got an error
102+
on system X: xxx " will help the maintainers in their evaluation. As a
103+
result, maintainers will be able to process CRs faster and everybody
104+
will gain from it.
105+
106+
Just browse through `the open CRs on Gerrit
107+
<https://gerrit.hyperledger.org/r/#/q/status:open>`__ to get started.
108+
90109
Making Feature/Enhancement Proposals
91110
------------------------------------
92111

0 commit comments

Comments
 (0)