Skip to content

Commit fecfdfb

Browse files
authored
Fix doc(hidden) errors. (#553)
Compiling with `cargo 1.63.0-nightly (3f052d8ee 2022-05-12)` I get lots of errors like this: ``` error: `#[doc(hidden)]` is ignored on trait impl items --> src/header/map.rs:3296:9 | 3296 | #[doc(hidden)] | ^^^^^^^^^^^^^^ help: remove this attribute | note: the lint level is defined here --> src/lib.rs:161:9 | 161 | #![deny(warnings, missing_docs, missing_debug_implementations)] | ^^^^^^^^ = note: `#[deny(unused_attributes)]` implied by `#[deny(warnings)]` = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: whether the impl item is `doc(hidden)` or not entirely depends on the corresponding trait item ``` This commit removes all these unnecessary attributes so that `http` compiles again with Nightly.
1 parent 9f68ed7 commit fecfdfb

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

src/header/map.rs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3293,19 +3293,16 @@ mod into_header_name {
32933293
// ==== impls ====
32943294

32953295
impl Sealed for HeaderName {
3296-
#[doc(hidden)]
32973296
#[inline]
32983297
fn insert<T>(self, map: &mut HeaderMap<T>, val: T) -> Option<T> {
32993298
map.insert2(self, val)
33003299
}
33013300

3302-
#[doc(hidden)]
33033301
#[inline]
33043302
fn append<T>(self, map: &mut HeaderMap<T>, val: T) -> bool {
33053303
map.append2(self, val)
33063304
}
33073305

3308-
#[doc(hidden)]
33093306
#[inline]
33103307
fn entry<T>(self, map: &mut HeaderMap<T>) -> Entry<'_, T> {
33113308
map.entry2(self)
@@ -3315,18 +3312,15 @@ mod into_header_name {
33153312
impl IntoHeaderName for HeaderName {}
33163313

33173314
impl<'a> Sealed for &'a HeaderName {
3318-
#[doc(hidden)]
33193315
#[inline]
33203316
fn insert<T>(self, map: &mut HeaderMap<T>, val: T) -> Option<T> {
33213317
map.insert2(self, val)
33223318
}
3323-
#[doc(hidden)]
33243319
#[inline]
33253320
fn append<T>(self, map: &mut HeaderMap<T>, val: T) -> bool {
33263321
map.append2(self, val)
33273322
}
33283323

3329-
#[doc(hidden)]
33303324
#[inline]
33313325
fn entry<T>(self, map: &mut HeaderMap<T>) -> Entry<'_, T> {
33323326
map.entry2(self)
@@ -3336,18 +3330,15 @@ mod into_header_name {
33363330
impl<'a> IntoHeaderName for &'a HeaderName {}
33373331

33383332
impl Sealed for &'static str {
3339-
#[doc(hidden)]
33403333
#[inline]
33413334
fn insert<T>(self, map: &mut HeaderMap<T>, val: T) -> Option<T> {
33423335
HdrName::from_static(self, move |hdr| map.insert2(hdr, val))
33433336
}
3344-
#[doc(hidden)]
33453337
#[inline]
33463338
fn append<T>(self, map: &mut HeaderMap<T>, val: T) -> bool {
33473339
HdrName::from_static(self, move |hdr| map.append2(hdr, val))
33483340
}
33493341

3350-
#[doc(hidden)]
33513342
#[inline]
33523343
fn entry<T>(self, map: &mut HeaderMap<T>) -> Entry<'_, T> {
33533344
HdrName::from_static(self, move |hdr| map.entry2(hdr))
@@ -3386,19 +3377,16 @@ mod as_header_name {
33863377
// ==== impls ====
33873378

33883379
impl Sealed for HeaderName {
3389-
#[doc(hidden)]
33903380
#[inline]
33913381
fn try_entry<T>(self, map: &mut HeaderMap<T>) -> Result<Entry<'_, T>, InvalidHeaderName> {
33923382
Ok(map.entry2(self))
33933383
}
33943384

3395-
#[doc(hidden)]
33963385
#[inline]
33973386
fn find<T>(&self, map: &HeaderMap<T>) -> Option<(usize, usize)> {
33983387
map.find(self)
33993388
}
34003389

3401-
#[doc(hidden)]
34023390
fn as_str(&self) -> &str {
34033391
<HeaderName>::as_str(self)
34043392
}
@@ -3407,19 +3395,16 @@ mod as_header_name {
34073395
impl AsHeaderName for HeaderName {}
34083396

34093397
impl<'a> Sealed for &'a HeaderName {
3410-
#[doc(hidden)]
34113398
#[inline]
34123399
fn try_entry<T>(self, map: &mut HeaderMap<T>) -> Result<Entry<'_, T>, InvalidHeaderName> {
34133400
Ok(map.entry2(self))
34143401
}
34153402

3416-
#[doc(hidden)]
34173403
#[inline]
34183404
fn find<T>(&self, map: &HeaderMap<T>) -> Option<(usize, usize)> {
34193405
map.find(*self)
34203406
}
34213407

3422-
#[doc(hidden)]
34233408
fn as_str(&self) -> &str {
34243409
<HeaderName>::as_str(*self)
34253410
}
@@ -3428,19 +3413,16 @@ mod as_header_name {
34283413
impl<'a> AsHeaderName for &'a HeaderName {}
34293414

34303415
impl<'a> Sealed for &'a str {
3431-
#[doc(hidden)]
34323416
#[inline]
34333417
fn try_entry<T>(self, map: &mut HeaderMap<T>) -> Result<Entry<'_, T>, InvalidHeaderName> {
34343418
HdrName::from_bytes(self.as_bytes(), move |hdr| map.entry2(hdr))
34353419
}
34363420

3437-
#[doc(hidden)]
34383421
#[inline]
34393422
fn find<T>(&self, map: &HeaderMap<T>) -> Option<(usize, usize)> {
34403423
HdrName::from_bytes(self.as_bytes(), move |hdr| map.find(&hdr)).unwrap_or(None)
34413424
}
34423425

3443-
#[doc(hidden)]
34443426
fn as_str(&self) -> &str {
34453427
self
34463428
}
@@ -3449,19 +3431,16 @@ mod as_header_name {
34493431
impl<'a> AsHeaderName for &'a str {}
34503432

34513433
impl Sealed for String {
3452-
#[doc(hidden)]
34533434
#[inline]
34543435
fn try_entry<T>(self, map: &mut HeaderMap<T>) -> Result<Entry<'_, T>, InvalidHeaderName> {
34553436
self.as_str().try_entry(map)
34563437
}
34573438

3458-
#[doc(hidden)]
34593439
#[inline]
34603440
fn find<T>(&self, map: &HeaderMap<T>) -> Option<(usize, usize)> {
34613441
Sealed::find(&self.as_str(), map)
34623442
}
34633443

3464-
#[doc(hidden)]
34653444
fn as_str(&self) -> &str {
34663445
self
34673446
}
@@ -3470,19 +3449,16 @@ mod as_header_name {
34703449
impl AsHeaderName for String {}
34713450

34723451
impl<'a> Sealed for &'a String {
3473-
#[doc(hidden)]
34743452
#[inline]
34753453
fn try_entry<T>(self, map: &mut HeaderMap<T>) -> Result<Entry<'_, T>, InvalidHeaderName> {
34763454
self.as_str().try_entry(map)
34773455
}
34783456

3479-
#[doc(hidden)]
34803457
#[inline]
34813458
fn find<T>(&self, map: &HeaderMap<T>) -> Option<(usize, usize)> {
34823459
Sealed::find(*self, map)
34833460
}
34843461

3485-
#[doc(hidden)]
34863462
fn as_str(&self) -> &str {
34873463
*self
34883464
}

0 commit comments

Comments
 (0)