Integrate VMA (Vulkan Memory Allocator) #15162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Nov 23, 2021
|
Why there's still no android build on automated buildbot? |
Collaborator
|
Should be there now. -[Unknown] |
ghost
mentioned this pull request
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMA is an open source project by AMD, which simplifies memory allocations in Vulkan and follows best practices, and is also very battle-tested - it's used by a number of commercial games and engines.
This replaces our own allocators with it. I don't see any regressions with regards to memory usage, and some stalls are gone (where we were allocating and freeing too many small-ish memory blocks for our push buffers).
Needs a bit more testing including Android, but after that I think this is probably the way to go.
(Now confirmed working on Android).
License of VMA is MIT, which should be fine.