[APctl] Fix stuck issue when scanning AP to Recruit on MGS:PW

[anr2me]

This should fix recruiting on MGS:PW using faked AP #8094

[CookiePLMonster]

Nitpick, but char dummyMAC[ETHER_ADDR_LEN] {}; will yield the same result without an explicit memset.

[anr2me]

Ah i forgot we can memset it using {x} to initialize it >.<

Edit: hmm.. using { entryId } without type casting it will get this warning warning C4838: conversion from 'int' to 'char' requires a narrowing conversion

[hrydgard]

I think CookiePLMonster thought you were zero-initializing it, in which case it would have worked.

You can remove the & sign though, leaving memset(dummyMAC, entryId, sizeof(dummyMAC));

[anr2me]

ah right, if i wanted to use & i need to explicitly pointing it to the first char like &dummy[0]

[hrydgard]

rand()*99+1 will not do what you think. rand() returns very large integer numbers, so the only thing limiting here is that you just write a byte.

Probably not worth messing with a better random generator here, so the "right" way to do this with rand() should be something like:

(int)(((float)rand()/(float)RAND_MAX)) * 99.0 + 1.0)

[anr2me]

Ah you're right, i was taking the code example from here https://www.cplusplus.com/reference/cstdlib/rand/
And it should be rand() % 99 instead of rand()*99 >.< i must have been sleepy, but this doesn't seems to be evenly spread across the range and tends to have small numbers.

Btw, is that supposed to be (int)(((float)rand() / (float)RAND_MAX) * 99.0 + 1.0) ? it seems to have too many )

[hrydgard]

yeah, that'd also be acceptable for this use case.

[hrydgard]

be aware that this will only set the first char of dummyMAC to entryId, the rest will be 0. that might be fine though. if you want all the bytes to be set to entryId, switch back to memset.

[anr2me]

eh.. it's not the same with memset? ugh okay, i'll change it back