Skip to content

Commit 4b18e61

Browse files
committed
fix: wasmBinary should be an ArrayBuffer
Signed-off-by: Gordon Smith <[email protected]>
1 parent 8fdd6f1 commit 4b18e61

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/expat.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class StackElement {
2727
export class StackParser implements IParser {
2828
private _stack: StackElement[] = [];
2929

30-
parse(xml: string, wasmFolder?: string, wasmBinary?: Uint8Array): Promise<boolean> {
30+
parse(xml: string, wasmFolder?: string, wasmBinary?: ArrayBuffer): Promise<boolean> {
3131
return parse(xml, this, wasmFolder, wasmBinary);
3232
}
3333

@@ -62,13 +62,13 @@ function parseAttrs(attrs: string): Attributes {
6262
return retVal;
6363
}
6464

65-
export function expatVersion(wasmFolder?: string, wasmBinary?: Uint8Array) {
65+
export function expatVersion(wasmFolder?: string, wasmBinary?: ArrayBuffer) {
6666
return loadWasm(expatlib, wasmFolder, wasmBinary).then(module => {
6767
return module.CExpat.prototype.version();
6868
});
6969
}
7070

71-
export function parse(xml: string, callback: IParser, wasmFolder?: string, wasmBinary?: Uint8Array): Promise<boolean> {
71+
export function parse(xml: string, callback: IParser, wasmFolder?: string, wasmBinary?: ArrayBuffer): Promise<boolean> {
7272
return loadWasm(expatlib, wasmFolder, wasmBinary).then(module => {
7373
const parser = new module.CExpatJS();
7474
parser.startElement = function () {

src/graphviz.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export interface Ext {
2020
images?: Image[];
2121
files?: File[];
2222
wasmFolder?: string;
23-
wasmBinary?: Uint8Array;
23+
wasmBinary?: ArrayBuffer;
2424
yInvert?: boolean;
2525
nop?: number;
2626
}
@@ -47,7 +47,7 @@ function createFiles(graphviz: any, _ext?: Ext) {
4747
[...ext.files, ...imagesToFiles(ext.images)].forEach(file => graphviz.createFile(file.path, file.data));
4848
}
4949

50-
export function graphvizVersion(wasmFolder?: string, wasmBinary?: Uint8Array) {
50+
export function graphvizVersion(wasmFolder?: string, wasmBinary?: ArrayBuffer) {
5151
return loadWasm(graphvizlib, wasmFolder, wasmBinary).then(module => {
5252
return module.Graphviz.prototype.version();
5353
});
@@ -143,6 +143,6 @@ export class GraphvizSync {
143143
}
144144
}
145145

146-
export function graphvizSync(wasmFolder?: string, wasmBinary?: Uint8Array): Promise<GraphvizSync> {
146+
export function graphvizSync(wasmFolder?: string, wasmBinary?: ArrayBuffer): Promise<GraphvizSync> {
147147
return loadWasm(graphvizlib, wasmFolder, wasmBinary).then(wasm => new GraphvizSync(wasm));
148148
}

src/util.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function getGlobal() {
66
}
77

88
const globalNS: any = getGlobal();
9-
9+
1010
let _wasmFolder: string | undefined = globalNS.__hpcc_wasmFolder || undefined;
1111
export function wasmFolder(_?: string): string | undefined {
1212
if (!arguments.length) return _wasmFolder;
@@ -29,15 +29,15 @@ function trimStart(str: string, charToRemove: string) {
2929
return str;
3030
}
3131

32-
export function loadWasm(_wasmLib: any, wf?: string, wasmBinary?: Uint8Array): Promise<any> {
32+
export function loadWasm(_wasmLib: any, wf?: string, wasmBinary?: ArrayBuffer): Promise<any> {
3333
const wasmLib = _wasmLib.default || _wasmLib;
3434
// Prevent double load ---
3535
if (!wasmLib.__hpcc_promise) {
3636
wasmLib.__hpcc_promise = wasmLib({
37-
wasmBinary,
38-
locateFile: (path: string, prefix: string) => {
39-
return `${trimEnd(wf || wasmFolder() || prefix || ".", "/")}/${trimStart(path, "/")}`;
40-
}
37+
wasmBinary,
38+
locateFile: (path: string, prefix: string) => {
39+
return `${trimEnd(wf || wasmFolder() || prefix || ".", "/")}/${trimStart(path, "/")}`;
40+
}
4141
});
4242
}
4343
return wasmLib.__hpcc_promise;

0 commit comments

Comments
 (0)