Merge pull request #48 from honeycombio/tredman.pylint

[setuptools] enforce lint errors in CI checks

Author: tredman

.travis.yml

@@ -3,8 +3,8 @@ python:
 - '2.7'
 - '3.5'
 - '3.6'
-install: pip install pyflakes==1.5.0
-script: pyflakes beeline && python setup.py test
+install: pip install pyflakes==1.5.0 pylint setuptools-lint
+script: pyflakes beeline && python setup.py lint --lint-rcfile pylint.rc && python setup.py test
 deploy:
   provider: pypi
   user: honeycomb

beeline/middleware/django/__init__.py

@@ -40,7 +40,7 @@ def __call__(self, execute, sql, params, many, context):
             else:
                 return result
             finally:
-                if vendor == "postgresql" or vendor == "mysql":
+                if vendor in ('postgresql', 'mysql'):
                     beeline.add_context({
                         "db.last_insert_id": context['cursor'].cursor.lastrowid,
                         "db.rows_affected": context['cursor'].cursor.rowcount,

beeline/test_trace.py

@@ -274,8 +274,8 @@ def test_run_hooks_and_send_no_hooks(self):
         # always call send_presampled
         # send should never be called because at a minimum we always do deterministic
         # sampling
-        m_span.event.send.assert_not_called()
-        m_span.event.send_presampled.assert_called_once_with()
+        m_span.event.send.assert_not_called() # pylint: disable=no-member
+        m_span.event.send_presampled.assert_called_once_with() # pylint: disable=no-member
 
     def test_run_hooks_and_send_sampler(self):
         ''' ensure send works with a sampler hook defined '''
@@ -293,8 +293,8 @@ def _sampler_drop_all(fields):
             tracer._run_hooks_and_send(m_span)
 
         # sampler ensures we drop everything
-        m_span.event.send.assert_not_called()
-        m_span.event.send_presampled.assert_not_called()
+        m_span.event.send.assert_not_called() # pylint: disable=no-member
+        m_span.event.send_presampled.assert_not_called() # pylint: disable=no-member
 
         def _sampler_drop_none(fields):
             return True, 100
@@ -308,8 +308,8 @@ def _sampler_drop_none(fields):
 
         # sampler drops nothing, _should_sample rigged to always return true so
         # we always call send_presampled
-        m_span.event.send.assert_not_called()
-        m_span.event.send_presampled.assert_called_once_with()
+        m_span.event.send.assert_not_called() # pylint: disable=no-member
+        m_span.event.send_presampled.assert_called_once_with() # pylint: disable=no-member
         # ensure event is updated with new sample rate
         self.assertEqual(m_span.event.sample_rate, 100)
 
@@ -335,7 +335,7 @@ def _presend_hook(fields):
             m_sample_fn.return_value = True
             tracer._run_hooks_and_send(m_span)
 
-        m_span.event.send_presampled.assert_called_once_with()
+        m_span.event.send_presampled.assert_called_once_with() # pylint: disable=no-member
         self.assertDictEqual(
             m_span.event.fields(),
             {