Skip to content
This repository was archived by the owner on May 12, 2022. It is now read-only.

Commit 0915ca3

Browse files
committed
Fix version number issues
1 parent f3e26bf commit 0915ca3

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

PlainPasta.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,7 @@
470470
CODE_SIGN_IDENTITY = "Mac Developer";
471471
CODE_SIGN_STYLE = Automatic;
472472
COMBINE_HIDPI_IMAGES = YES;
473+
CURRENT_PROJECT_VERSION = 1.1.5;
473474
DEVELOPMENT_TEAM = F2J52QJQ9Y;
474475
ENABLE_HARDENED_RUNTIME = YES;
475476
FRAMEWORK_SEARCH_PATHS = "$(inherited)";
@@ -494,6 +495,7 @@
494495
CODE_SIGN_IDENTITY = "Mac Developer";
495496
CODE_SIGN_STYLE = Automatic;
496497
COMBINE_HIDPI_IMAGES = YES;
498+
CURRENT_PROJECT_VERSION = 1.1.5;
497499
DEVELOPMENT_TEAM = F2J52QJQ9Y;
498500
ENABLE_HARDENED_RUNTIME = YES;
499501
FRAMEWORK_SEARCH_PATHS = "$(inherited)";

PlainPasta/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<key>CFBundleShortVersionString</key>
2020
<string>$(MARKETING_VERSION)</string>
2121
<key>CFBundleVersion</key>
22-
<string>1</string>
22+
<string>$(CURRENT_PROJECT_VERSION)</string>
2323
<key>LSApplicationCategoryType</key>
2424
<string>public.app-category.utilities</string>
2525
<key>LSMinimumSystemVersion</key>

PlainPasta/LocalizedStrings.swift

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,10 @@ enum LocalizedStrings {
3939
comment: "The word for 'Version'"
4040
)
4141

42-
/// Localized version of the word "build"
43-
/// For use in representing the app's build number
44-
static let buildTitle = NSLocalizedString(
45-
"buildTitle",
46-
value: "build",
47-
comment: "The word for 'build'"
48-
)
49-
50-
/// Localized version of the app's full version and build number
51-
/// Formatted as: "Version 1.0.1 (build 12)"
42+
/// Localized version of the app's version number
43+
/// Formatted as: "Version 1.0.1"
5244
static var appVersion: String {
5345
let versionNumber = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String ?? "?"
54-
let buildNumber = Bundle.main.object(forInfoDictionaryKey: "CFBundleVersion") as? String ?? "?"
55-
return "\(versionTitle) \(versionNumber) (\(buildTitle) \(buildNumber))"
46+
return "\(versionTitle) \(versionNumber)"
5647
}
5748
}

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
99
### Changed
1010

1111
- Significant refactor of code structure to make future updates easier.
12+
- Changed build numbering scheme to comply with App Store requirements.
1213

1314
### Fixed
1415

0 commit comments

Comments
 (0)