Skip to content

Commit d4b4470

Browse files
JLHwungNoahDragon
authored andcommitted
Revert "hotfix(file): cast dev to uint32" (#2889)
* Revert "hotfix(file): cast dev to uint32" This reverts commit a218422. Since nodejs/node#16705 is merged, the hotfix is unecessary. * test(appveyor): update to exact node.js version
1 parent c8d47b8 commit d4b4470

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

appveyor.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ init:
55
# Test against these versions of Node.js.
66
environment:
77
matrix:
8-
- nodejs_version: "6"
9-
- nodejs_version: "8"
8+
- nodejs_version: "6.12.2"
9+
- nodejs_version: "8.9.3"
1010

1111
matrix:
1212
fast_finish: true
1313

1414
# Install scripts. (runs after repo cloning)
1515
install:
16-
- ps: Install-Product node $env:nodejs_version
16+
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
1717
- npm install -g npm
1818
- npm install
1919

test/scripts/box/file.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ describe('File', () => {
7373
file.stat((err, fileStats) => {
7474
if (err) return callback(err);
7575

76-
//todo: cast dev to uint32 until https://github.com/nodejs/node/issues/16496 is resolved
77-
fileStats.dev = (new Uint32Array([fileStats.dev]))[0];
7876
fileStats.should.eql(fs.statSync(file.source));
7977
callback();
8078
});

0 commit comments

Comments
 (0)