Crash problem is fixed when an adress could not be translated by address provider. (#1073) (#1074)

Author: OzanCansel

hazelcast/src/hazelcast/client/network.cpp

@@ -917,7 +917,24 @@ ClientConnectionManagerImpl::translate(const member& m)
         return m.get_address();
     }
 
-    return *address_provider_->translate(m.get_address());
+    try {
+        boost::optional<address> addr =
+          address_provider_->translate(m.get_address());
+
+        if (!addr) {
+            throw exception::hazelcast_(boost::str(
+              boost::format("Address Provider could not translate %1%") % m));
+        }
+
+        return *addr;
+    } catch (const exception::hazelcast_&) {
+        logger_.log(
+          logger::level::warning,
+          boost::str(boost::format("Address Provider could not translate %1%") %
+                     m));
+
+        throw;
+    }
 }
 
 std::shared_ptr<connection::Connection>

hazelcast/test/src/HazelcastTests8.cpp

@@ -37,6 +37,7 @@
 #include <hazelcast/client/connection/ClientConnectionManagerImpl.h>
 #include <hazelcast/client/connection/Connection.h>
 #include <hazelcast/client/connection/AddressProvider.h>
+#include <hazelcast/client/spi/impl/discovery/remote_address_provider.h>
 #include <hazelcast/client/entry_event.h>
 #include <hazelcast/client/exception/protocol_exceptions.h>
 #include <hazelcast/client/hazelcast_client.h>
@@ -2316,6 +2317,29 @@ TEST_F(connection_manager_translate, default_config_uses_private_addresses)
 {
     ASSERT_FALSE(client_config().get_network_config().use_public_address());
 }
+
+TEST_F(
+  connection_manager_translate,
+  if_remote_adress_provider_cannot_translate_adress_translate_should_throw_an_exception)
+{
+    auto client = new_client().get();
+    spi::ClientContext ctx(client);
+    connection::ClientConnectionManagerImpl connection_manager(
+      ctx,
+      std::unique_ptr<connection::AddressProvider>(
+        new spi::impl::discovery::remote_address_provider{
+          []() { return std::unordered_map<address, address>{}; }, true }));
+
+    std::random_device rand{};
+    member dummy_member(
+      address{ "255.255.255.255", 40000 },
+      boost::uuids::basic_random_generator<std::random_device>{ rand }(),
+      false,
+      std::unordered_map<std::string, std::string>{},
+      std::unordered_map<endpoint_qualifier, address>{});
+    EXPECT_THROW(connection_manager.get_or_connect(dummy_member),
+                 exception::hazelcast_);
+}
 } // namespace test
 } // namespace client
 } // namespace hazelcast