mypy: enable some error codes

Author: hauntsaninja

boostedblob/__init__.py

@@ -5,7 +5,7 @@
 if "pkg_resources" not in sys.modules:
     # workaround for the following:
     # https://github.com/benoitc/gunicorn/pull/2539
-    sys.modules["pkg_resources"] = object()  # type: ignore
+    sys.modules["pkg_resources"] = object()  # type: ignore[assignment]
     import aiohttp
 
     del sys.modules["pkg_resources"]

boostedblob/cli.py

@@ -32,7 +32,7 @@ def wrapper(*args: Any, **kwargs: Any) -> Any:
 
 
 def sync_with_session(fn: F) -> F:
-    return syncify(bbb.ensure_session(fn))  # type: ignore
+    return syncify(bbb.ensure_session(fn))  # type: ignore[return-value]
 
 
 DEFAULT_CONCURRENCY = int(os.environ.get("BBB_DEFAULT_CONCURRENCY", 100))

boostedblob/globals.py

@@ -183,7 +183,7 @@ async def wrapper(*args: Any, **kwargs: Any) -> Any:
         async with session_context():
             return await fn(*args, **kwargs)
 
-    return wrapper  # type: ignore
+    return wrapper  # type: ignore[return-value]
 
 
 def set_event_loop_exception_handler() -> None:

boostedblob/path.py

@@ -46,7 +46,7 @@ def relative_to(self: T, other: T) -> str:
 
     def is_relative_to(self: T, other: T) -> bool:
         try:
-            self.relative_to(other)  # type: ignore
+            self.relative_to(other)  # type: ignore[attr-defined]
             return True
         except ValueError:
             return False
@@ -249,7 +249,7 @@ def pathdispatch(fn: F) -> F:
     causes type checkers to complain about "no attribute register"
 
     """
-    ret: F = functools.singledispatch(fn)  # type: ignore
+    ret: F = functools.singledispatch(fn)  # type: ignore[assignment]
 
     @ret.register  # type: ignore
     def strdispatch(path: str, *args: Any, **kwargs: Any) -> Any:

pyproject.toml

@@ -22,6 +22,7 @@ strict = true
 no_warn_return_any = true
 python_version = "3.7"
 show_error_codes = true
+enable_error_code = ["redundant-expr", "truthy-bool"]
 
 [[tool.mypy.overrides]]
 module = "tests.*"