Fix bug setting PKI issuer enable_aia_url_templating to be set to false (#28832)

victorr · victorr · commit 37b9f82b4af3 · 2024-11-04T15:54:30.000-05:00
diff --git a/builtin/logical/pki/path_fetch_issuers.go b/builtin/logical/pki/path_fetch_issuers.go
@@ -894,7 +894,7 @@ func (b *backend) pathPatchIssuer(ctx context.Context, req *logical.Request, dat
 	if enableTemplatingRaw, ok := data.GetOk("enable_aia_url_templating"); ok {
 		enableTemplating := enableTemplatingRaw.(bool)
 		if enableTemplating != issuer.AIAURIs.EnableTemplating {
-			issuer.AIAURIs.EnableTemplating = true
+			issuer.AIAURIs.EnableTemplating = enableTemplating
 			modified = true
 		}
 	}
diff --git a/changelog/28832.txt b/changelog/28832.txt
@@ -0,0 +1,4 @@
+```release-note:bug
+secret/pki: Fix a bug that prevents PKI issuer field enable_aia_url_templating
+to be set to false.
+```

Original file line number	Diff line number	Diff line change
`@@ -894,7 +894,7 @@ func (b backend) pathPatchIssuer(ctx context.Context, req logical.Request, dat`
`894`	`894`	`if enableTemplatingRaw, ok := data.GetOk("enable_aia_url_templating"); ok {`
`895`	`895`	`enableTemplating := enableTemplatingRaw.(bool)`
`896`	`896`	`if enableTemplating != issuer.AIAURIs.EnableTemplating {`
`897`		`- issuer.AIAURIs.EnableTemplating = true`
	`897`	`+ issuer.AIAURIs.EnableTemplating = enableTemplating`
`898`	`898`	`modified = true`
`899`	`899`	`}`
`900`	`900`	`}`