Skip to content

Commit 98be3cb

Browse files
committed
use named return for retErr
1 parent f44e2c1 commit 98be3cb

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

internal/db/schema/manager.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,9 @@ func (b *Manager) ApplyMigrations(ctx context.Context) ([]RepairLog, error) {
243243
// runMigrations passes migration queries to a database driver and manages
244244
// the version and dirty bit. Cancellation or deadline/timeout is managed
245245
// through the passed in context.
246-
func (b *Manager) runMigrations(ctx context.Context, p *provider.Provider) ([]RepairLog, error) {
246+
func (b *Manager) runMigrations(ctx context.Context, p *provider.Provider) (logEntries []RepairLog, retErr error) {
247247
const op = "schema.(Manager).runMigrations"
248248

249-
var logEntries []RepairLog
250-
var retErr error
251-
252249
if startErr := b.driver.StartRun(ctx); startErr != nil {
253250
return nil, errors.Wrap(ctx, startErr, op)
254251
}
@@ -312,5 +309,5 @@ func (b *Manager) runMigrations(ctx context.Context, p *provider.Provider) ([]Re
312309
return nil, errors.Wrap(ctx, err, op)
313310
}
314311

315-
return logEntries, retErr
312+
return logEntries, nil
316313
}

0 commit comments

Comments
 (0)