Skip to content

Commit 897ce1c

Browse files
backport of commit dfdbb4f
1 parent 626bab9 commit 897ce1c

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

internal/auth/oidc/repository_managed_group_members.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ func (r *Repository) SetManagedGroupMemberships(ctx context.Context, am *AuthMet
111111
msgs = append(msgs, &mgOplogMsg)
112112
}
113113

114-
currentMemberships, err = r.ListManagedGroupMembershipsByMember(ctx, acct.PublicId, WithReader(reader))
114+
currentMemberships, err = r.ListManagedGroupMembershipsByMember(ctx, acct.PublicId, WithReader(reader), WithLimit(-1))
115115
if err != nil {
116116
return errors.Wrap(ctx, err, op, errors.WithMsg("unable to retrieve current managed group memberships before deletion"))
117117
}
@@ -181,7 +181,7 @@ func (r *Repository) SetManagedGroupMemberships(ctx context.Context, am *AuthMet
181181
}
182182
}
183183

184-
currentMemberships, err = r.ListManagedGroupMembershipsByMember(ctx, acct.PublicId, WithReader(reader))
184+
currentMemberships, err = r.ListManagedGroupMembershipsByMember(ctx, acct.PublicId, WithReader(reader), WithLimit(-1))
185185
if err != nil {
186186
return errors.Wrap(ctx, err, op, errors.WithMsg("unable to retrieve current managed group memberships after set"))
187187
}

internal/auth/oidc/service_callback.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func Callback(
193193
}
194194

195195
// Get the set of all managed groups so we can filter
196-
mgs, _, err := r.ListManagedGroups(ctx, am.GetPublicId())
196+
mgs, _, err := r.ListManagedGroups(ctx, am.GetPublicId(), WithLimit(-1))
197197
if err != nil {
198198
return "", errors.Wrap(ctx, err, op)
199199
}

internal/auth/oidc/service_callback_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,8 @@ func Test_ManagedGroupFiltering(t *testing.T) {
675675
return iam.NewRepository(ctx, rw, rw, kmsCache)
676676
}
677677
repoFn := func() (*Repository, error) {
678-
return NewRepository(ctx, rw, rw, kmsCache)
678+
// Set a low limit to test that the managed group listing overrides the limit
679+
return NewRepository(ctx, rw, rw, kmsCache, WithLimit(1))
679680
}
680681
atRepoFn := func() (*authtoken.Repository, error) {
681682
return authtoken.NewRepository(ctx, rw, rw, kmsCache)
@@ -819,7 +820,7 @@ func Test_ManagedGroupFiltering(t *testing.T) {
819820
tp.SetExpectedState(state)
820821

821822
// Set the filters on the MGs for this test. First we need to get the current versions.
822-
currMgs, ttime, err := repo.ListManagedGroups(ctx, testAuthMethod.PublicId)
823+
currMgs, ttime, err := repo.ListManagedGroups(ctx, testAuthMethod.PublicId, WithLimit(-1))
823824
require.NoError(err)
824825
// Transaction timestamp should be within ~10 seconds of now
825826
assert.True(time.Now().Before(ttime.Add(10 * time.Second)))
@@ -860,7 +861,7 @@ func Test_ManagedGroupFiltering(t *testing.T) {
860861
assert.Contains(key.(map[string]any)["payload"], "auth_token_end")
861862
}
862863
// Ensure that we get the expected groups
863-
memberships, err := repo.ListManagedGroupMembershipsByMember(ctx, account.PublicId)
864+
memberships, err := repo.ListManagedGroupMembershipsByMember(ctx, account.PublicId, WithLimit(-1))
864865
require.NoError(err)
865866
assert.Equal(len(tt.matchingMgs), len(memberships))
866867
var matchingIds []string

0 commit comments

Comments
 (0)