You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Start on hole 1 and refactor the code to be like the code in hole 2
47
+
- put your names in README ETUDIANTS.md; commit and push.
48
+
- Create a Pull Request on Exo01
42
49
- Use a diff tool to see the differences in code between the starting hole and end hole
43
-
- Move to hole 2 and refactor the code from hole 2 to be like the code in hole 3
44
-
- Apply the same pattern until you reach hole 13
50
+
- write your annotations, remarks... spot the problem(s)
51
+
- make a refactoring to the code, to fix the problem
52
+
- be sure the tests are green
53
+
- review your changes
54
+
- push (but don't merge) the pull request to the original repository
55
+
56
+
- Move to Exo 2 and do the same to refactor the code from Exo 2 to be like the code in Exo 3
57
+
- Apply the same pattern until you reach hole 8
45
58
- Remember to keep the code compiling and the tests passing at all times during the refactor
46
59
- For every refactor, run the tests, and if they pass, commit
47
60
- It's okay, and actually heavily encouraged, to revert back to a previous working state at any moment
48
-
- Give each hole at least 3 attempts for each run.
61
+
49
62
50
63
## Before you start
51
64
52
-
- Make sure you have identified as many code smells on the starting hole as possible.
53
65
- Make sure the code builds, and tests are passing `yarn test`
54
66
55
67
## First run
@@ -61,22 +73,10 @@ yarn test:ci
61
73
- do the refactoring
62
74
- create a Pull Request
63
75
64
-
## Second run
76
+
## other runs
65
77
66
78
- Refactor the code following the treatment available for each code smell in <https://refactoring.guru/refactoring/smells>.
67
-
- Using pen and pencil, take note of the following:
68
-
- For every compilation error you get during or after a refactor, count 1 strike.
69
-
- For every failing test during or after a refactor, count 2 strikes.
70
-
71
-
## Third run
72
-
73
-
- Refactor the code following the treatment available for each code smell in <https://refactoring.guru/refactoring/smells>. Use automated IDE refactoring as much as possible.
74
-
- Using pen and pencil, take note of the following:
75
-
- For every manual edit, count 1 strike.
76
-
- Any code formatting applied does not count as a manual edit
77
-
- Deleting blank lines or blank spaces does not count as a manual edit
78
-
- For every compilation error you get during or after a refactor, count 1 strike.
79
-
- For every failing test during or after a refactor, count 2 strikes.
0 commit comments