fix: PDF471 codes on desktop Mac #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native BarcodeDetector implementation on desktop Mac seems to support PDF417 codes but when scanning (always?) returns an empty string. Thus, now falling back to polyfill under these conditions. See: #459
Deploying vue-qrcode-reader with
|
| Latest commit: |
1b56055
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f58f2fb.vue-qrcode-reader.pages.dev |
| Branch Preview URL: | https://pdf417-macos.vue-qrcode-reader.pages.dev |
Owner
Author
|
@joleeee Would you mind checking if this works? I have a Mac but it has no camera. I know this fix is quite ad-hoc. I'm sure there are more situations where the native BarcodeDetector implementation is problematic. But I think the best way to find out about these cases, is to wait for users to run into them and open issues. |
|
Yup, it works @gruhn |
|
🎉 This PR is included in version 5.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native BarcodeDetector implementation on desktop Mac seems to support PDF417 codes but when scanning (always?) returns an empty string. Thus, now falling back to polyfill under these conditions.
See: #459