Skip to content

Commit 7996aab

Browse files
authored
chore: do not use renovate to update protobuf (#3190)
In this PR: - Do not use renovate to update protobuf version in `gax-java/dependencies.properties`. We need to make sure the protobuf version in `gax-java/dependency.properties` (used by the self-service client) is compatible with protoc/protobuf version defined in the generator. We'll manually change the version. Verification: ``` export LOG_LEVEL=debug && npx --yes --package renovate -- renovate --platform=local ... { "datasource": "maven", "depName": "com.google.protobuf:protobuf-bom", "currentValue": "3.25.4", "fileReplacePosition": 1523, "registryUrls": [ "https://maven-central.storage-download.googleapis.com/maven2/", "https://maven-central.storage-download.googleapis.com/maven2", "https://repo1.maven.org/maven2", "https://repo.maven.apache.org/maven2" ], "depType": "import", "groupName": "protobuf.version", "editFile": "gapic-generator-java-pom-parent/pom.xml", "updates": [], "packageName": "com.google.protobuf:protobuf-bom", "skipReason": "disabled" }, ```
1 parent badca93 commit 7996aab

File tree

1 file changed

+6
-30
lines changed

1 file changed

+6
-30
lines changed

renovate.json

Lines changed: 6 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,29 +18,6 @@
1818
],
1919
"datasourceTemplate": "maven"
2020
},
21-
{
22-
"customType": "regex",
23-
"fileMatch": [
24-
"^gax-java/dependencies\\.properties$"
25-
],
26-
"matchStrings": [
27-
"version\\.com_google_protobuf=(?<currentValue>.+?)\\n"
28-
],
29-
"depNameTemplate": "com.google.protobuf:protobuf-java",
30-
"datasourceTemplate": "maven"
31-
},
32-
{
33-
"customType": "regex",
34-
"fileMatch": [
35-
"^\\.cloudbuild/library_generation/library_generation\\.Dockerfile$"
36-
],
37-
"matchStrings": [
38-
"ARG PROTOC_VERSION=[\"']?(?<currentValue>.+?)[\"']?\\s+"
39-
],
40-
"datasourceTemplate": "github-releases",
41-
"depNameTemplate": "protocolbuffers/protobuf",
42-
"extractVersionTemplate": "^v(?<version>.*)$"
43-
},
4421
{
4522
"customType": "regex",
4623
"fileMatch": [
@@ -95,6 +72,12 @@
9572
],
9673
"enabled": false
9774
},
75+
{
76+
"matchPackagePatterns": [
77+
"^com.google.protobuf:"
78+
],
79+
"enabled": false
80+
},
9881
{
9982
"matchPackagePatterns": [
10083
"^com.google.guava:"
@@ -153,13 +136,6 @@
153136
],
154137
"groupName": "jackson dependencies"
155138
},
156-
{
157-
"matchPackagePatterns": [
158-
"^com.google.protobuf",
159-
"^protocolbuffers/protobuf"
160-
],
161-
"groupName": "Protobuf dependencies"
162-
},
163139
{
164140
"matchPackagePatterns": [
165141
"^io.grpc"

0 commit comments

Comments
 (0)