Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 2234e91

Browse files
build: update dependencies check to only check for runtime and compile scopes (#198)
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4f159194-de9c-4c80-934e-eb32cd08c411/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@f8823de
1 parent 671a8ce commit 2234e91

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.kokoro/dependencies.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,13 @@ function completenessCheck() {
4343
# Output dep list with compile scope generated using the original pom
4444
# Running mvn dependency:list on Java versions that support modules will also include the module of the dependency.
4545
# This is stripped from the output as it is not present in the flattened pom.
46+
# Only dependencies with 'compile' or 'runtime' scope are included from original dependency list.
4647
msg "Generating dependency list using original pom..."
47-
mvn dependency:list -f pom.xml -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e s/\\s--\\smodule.*// | grep -v ':test$' >.org-list.txt
48+
mvn dependency:list -f pom.xml -DincludeScope=runtime -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | sed -e s/\\s--\\smodule.*// >.org-list.txt
4849

49-
# Output dep list generated using the flattened pom (test scope deps are ommitted)
50+
# Output dep list generated using the flattened pom (only 'compile' and 'runtime' scopes)
5051
msg "Generating dependency list using flattened pom..."
51-
mvn dependency:list -f .flattened-pom.xml -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' >.new-list.txt
52+
mvn dependency:list -f .flattened-pom.xml -DincludeScope=runtime -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' >.new-list.txt
5253

5354
# Compare two dependency lists
5455
msg "Comparing dependency lists..."
@@ -85,4 +86,4 @@ then
8586
else
8687
msg "Errors found. See log statements above."
8788
exit 1
88-
fi
89+
fi

synth.metadata

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/java-vision.git",
7-
"sha": "24126ba9643d8d7c21510c5a542fc00338edee17"
7+
"sha": "671a8cef44e50fd10330b2a8b7e8f9eab0311f07"
88
}
99
},
1010
{
@@ -51,7 +51,7 @@
5151
"git": {
5252
"name": "synthtool",
5353
"remote": "https://github.com/googleapis/synthtool.git",
54-
"sha": "4530cc6ff080ef8aca258c1ec92c4db10a1bbfb4"
54+
"sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"
5555
}
5656
}
5757
],

0 commit comments

Comments
 (0)