Regression quoting empty string?

[p3k]

I upgraded zx from 8.2.0 to 8.5.4 and now see an error in a Docker command I am composing:

const { $ } = await import("zx");
const args = [""];
await $`docker run ${args} debian:12.0-slim uname`

Version 8.2.0:

ProcessOutput {
  stdout: 'Linux\n',
  stderr: '',
  signal: null,
  exitCode: 0,
  duration: 440
}

Version 8.5.4:

ProcessOutput {
  stdout: '',
  stderr: 'docker: invalid reference format\n' +
  '\n' +
  "Run 'docker run --help' for more information\n",
  signal: null,
  exitCode: 125,
  duration: 26
}

I saw the section in the changelog about quoting empty strings, as well as the references to #999 and #1113:

The quote has been slightly changed for a conner case, when zx literal gets an array.
#​999 #​1113

const p = $({prefix: '', postfix: ''})`echo ${[1, '', '*', '2']}`

// before
p.cmd //  `echo 1  $'*' 2`) 

// after
p.cmd //  `echo 1 $'' $'*' 2`) 

Am I doing something wrong when composing the Docker command or is it assumed that all binaries can resolve the Bash variable syntax $"", accordingly?

[p3k]

Nobody here to help me out?

[p3k]

My current take-away is that since the changes in #999 and #1113 it is a bad idea to construct arguments with an empty string – it should always be an empty array:

# 🟥 Does not work
$await $`docker run ${""} debian:12.0-slim uname`
docker: invalid reference format

Run 'docker run --help' for more information
Uncaught:
ProcessOutput {
  stdout: '',
  stderr: 'docker: invalid reference format\n' +
  '\n' +
  "Run 'docker run --help' for more information\n",
  signal: null,
  exitCode: 125,
  duration: 20
}

# 🟩 Works
$ await $`docker run ${[]} debian:12.0-slim uname`
ProcessOutput {
  stdout: 'Linux\n',
  stderr: '',
  signal: null,
  exitCode: 0,
  duration: 403
}